◐ Shell
reader mode source ↗
Skip to content

gh-123085: Fix issue in inferred caller when resources package has no source#123102

Merged
jaraco merged 2 commits into
python:mainfrom
jaraco:gh-123085/inferred-compiled
Sep 12, 2024
Merged

gh-123085: Fix issue in inferred caller when resources package has no source#123102
jaraco merged 2 commits into
python:mainfrom
jaraco:gh-123085/inferred-compiled

Conversation

@jaraco

@jaraco jaraco commented Aug 17, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

@jaraco jaraco changed the title Fix issue in inferred caller when resources package has no source Aug 17, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Aug 17, 2024
Open
@jaraco jaraco added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Aug 17, 2024
@jaraco jaraco marked this pull request as ready for review September 12, 2024 09:02
@jaraco jaraco force-pushed the gh-123085/inferred-compiled branch from e4bfe86 to b6bd51d Compare September 12, 2024 09:18
@jaraco jaraco mentioned this pull request Sep 12, 2024
Merged
1 task
@jaraco jaraco force-pushed the gh-123085/inferred-compiled branch from b6bd51d to 097b06c Compare September 12, 2024 18:38
@jaraco

jaraco commented Sep 12, 2024

Copy link
Copy Markdown
Member Author

I'm proceeding with a merge to unblock #124018.

@jaraco jaraco enabled auto-merge (squash) September 12, 2024 18:49
@jaraco jaraco merged commit a53812d into python:main Sep 12, 2024
@miss-islington-app

miss-islington-app Bot commented Sep 12, 2024

Copy link
Copy Markdown

Thanks @jaraco for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@bedevere-app bedevere-app Bot removed the label Sep 12, 2024
@miss-islington-app

miss-islington-app Bot commented Sep 12, 2024

Copy link
Copy Markdown

Sorry, @jaraco, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker a53812df126b99bca25187441a123c7785ee82a0 3.13

@miss-islington-app

miss-islington-app Bot commented Sep 12, 2024

Copy link
Copy Markdown

Sorry, @jaraco, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker a53812df126b99bca25187441a123c7785ee82a0 3.12

@jaraco jaraco deleted the gh-123085/inferred-compiled branch September 12, 2024 19:38
@jaraco

jaraco commented Sep 12, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

The backport to 3.13 is blocked by:

jaraco added a commit to jaraco/cpython that referenced this pull request Sep 12, 2024
@jaraco
[3.12] pythongh-123085: Fix issue in inferred caller when resources p… …
70b4561 
…ackage has no source (pythonGH-123102)

pythongh-123085: Fix issue in inferred caller when resources package has no source.

From importlib_resources 6.4.3 (python/importlib_resourcesGH-314).
(cherry picked from commit a53812d)

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
@bedevere-app

bedevere-app Bot commented Sep 12, 2024

Copy link
Copy Markdown

GH-124021 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Sep 12, 2024
jaraco added a commit to jaraco/cpython that referenced this pull request Sep 12, 2024
@jaraco
[3.13] pythongh-123085: Fix issue in inferred caller when resource pa… …
50c8d2d 
…ckage has no source (pythonGH-123102)
@jaraco jaraco mentioned this pull request Sep 12, 2024
Merged
1 task
@bedevere-app

bedevere-app Bot commented Sep 12, 2024

Copy link
Copy Markdown

GH-124024 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Sep 12, 2024
@jaraco jaraco mentioned this pull request Jan 5, 2025
Merged
jaraco added a commit that referenced this pull request Jan 5, 2025
@jaraco
[3.12] gh-123085: Fix issue in inferred caller when resources package… …
d712ece 
… has no source (GH-123102) (#124021)

gh-123085: Fix issue in inferred caller when resources package has no source.

From importlib_resources 6.4.3 (python/importlib_resourcesGH-314).
(cherry picked from commit a53812d)
jaraco added a commit that referenced this pull request Aug 15, 2025
@jaraco
[3.13] gh-123085: Fix issue in inferred caller when resource package … …
0607fdd 
…has no source (GH-123102) (#124024)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 is a code owner

@brettcannon brettcannon Awaiting requested review from brettcannon

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently

@ncoghlan ncoghlan Awaiting requested review from ncoghlan

@erlend-aasland erlend-aasland

Assignees

@jaraco jaraco

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jaraco