◐ Shell
reader mode source ↗
Skip to content

bpo-36333: Fix leaks in pymain_init and _PyPreConfig_ReadFromArgv#12389

Closed
matrixise wants to merge 1 commit into
python:masterfrom
matrixise:bpo-36333
Closed

bpo-36333: Fix leaks in pymain_init and _PyPreConfig_ReadFromArgv#12389
matrixise wants to merge 1 commit into
python:masterfrom
matrixise:bpo-36333

Conversation

@matrixise

@matrixise matrixise commented Mar 17, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@matrixise matrixise marked this pull request as ready for review March 18, 2019 00:22
@matrixise matrixise closed this Mar 18, 2019
@matrixise matrixise reopened this Mar 18, 2019
vstinner
vstinner requested changes Mar 18, 2019
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Hum, I think that I will rewrite your PR because I'm in the middle of a big refactoring, and the correct fix for your bug requires more fixes.

But please write a separated PR for _PyRuntimeState_Fini.

@bedevere-bot

bedevere-bot commented Mar 18, 2019

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@matrixise

matrixise commented Mar 18, 2019

Copy link
Copy Markdown
Member Author

This PR is superseded by #12400. @vstinner thank your review.

@matrixise matrixise closed this Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner

+1 more reviewer

@btharper btharper btharper left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@matrixise @bedevere-bot @vstinner @btharper @the-knights-who-say-ni