GH-95468: Prevent argparse from removing -- in cases where used to delineate positional args#124145
GH-95468: Prevent argparse from removing -- in cases where used to delineate positional args#124145savannahostrowski wants to merge 13 commits into
-- in cases where used to delineate positional args#124145Conversation
|
Perhaps @serhiy-storchaka you can take a look? I think you updated this conditional and added some additional tests for -- in #114814 |
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
This does not work for This issue may require a fix at different level. I'll try to resolve it. |
Sorry, something went wrong.
|
Ah, thanks for the review, @serhiy-storchaka. It was my mistake to expect tests to catch some of these. I can take another look and add additional tests here. |
Sorry, something went wrong.
|
@serhiy-storchaka I've updated the PR. Does this cover the test cases you were thinking of? Or do you already have another PR in progress? |
Sorry, something went wrong.
|
This is not enough. |
Sorry, something went wrong.
|
I am afraid that my reaction may not have seemed very friendly to you. In this case, I apologize and make sure that the reason for this is only my bad English and my fatigue. I didn't mean anything bad. It's just that in this case your approach was a dead end, this problem needed to be solved at another level. I've already spent half a day creating a solution, and creating a new PR was much easier than leading you to incrementally modify your PR. It happens to everyone, even major developers close their PRs. My main mistake was that I did not know words how to say this to you. I look forward to working with you. |
Sorry, something went wrong.
edited by bedevere-app
Bot
LoadingUh oh!
There was an error while loading. Please reload this page.
Copy link Copy MarkdownSorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.