◐ Shell
reader mode source ↗
Skip to content

gh-81691: Fix handling of multiple "--" (double dashes) in argparse#124233

Merged
serhiy-storchaka merged 2 commits into
python:mainfrom
serhiy-storchaka:argparse-double-dash
Sep 20, 2024
Merged

gh-81691: Fix handling of multiple "--" (double dashes) in argparse#124233
serhiy-storchaka merged 2 commits into
python:mainfrom
serhiy-storchaka:argparse-double-dash

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Sep 19, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Only the first one has now been removed, all subsequent ones are now taken literally.

@serhiy-storchaka serhiy-storchaka added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Sep 19, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Sep 19, 2024
Closed
@serhiy-storchaka serhiy-storchaka mentioned this pull request Sep 19, 2024
Closed
@savannahostrowski

savannahostrowski commented Sep 19, 2024

Copy link
Copy Markdown
Member

Thanks for putting up the PR. I was going back through a couple of other bugs in argparse related to the handling of --, and I think that nargs=argparse.REMAINDER still isn't going to behave correctly here (I pulled down the branch and the repro cases in #66419 still don't work as expected).

I know that REMAINDER was made undocumented via #61252, but I think we'd probably still want to update this as well?

@serhiy-storchaka

serhiy-storchaka commented Sep 19, 2024

Copy link
Copy Markdown
Member Author

Yes, but changing this behavior requires more significant rewriting. I am planning to do this later.

@serhiy-storchaka serhiy-storchaka changed the title gh-95468: Fix handling of multiple "--" (double dashes) in argparse Sep 19, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Sep 19, 2024
Closed
@serhiy-storchaka
pythongh-81691: Fix handling of multiple "--" (double dashes) in argp… …
34884b2 
…arse

Only the first one has now been removed, all subsequent ones are now
taken literally.
@serhiy-storchaka serhiy-storchaka merged commit aae1267 into python:main Sep 20, 2024
@miss-islington-app

miss-islington-app Bot commented Sep 20, 2024

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the argparse-double-dash branch September 20, 2024 06:20
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 20, 2024
@serhiy-storchaka @miss-islington
pythongh-81691: Fix handling of multiple "--" (double dashes) in argp… …
6de1754 
…arse (pythonGH-124233)

Only the first one has now been removed, all subsequent ones are now
taken literally.
(cherry picked from commit aae1267)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app

bedevere-app Bot commented Sep 20, 2024

Copy link
Copy Markdown

GH-124266 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Sep 20, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 20, 2024
@serhiy-storchaka @miss-islington
pythongh-81691: Fix handling of multiple "--" (double dashes) in argp… …
3426976 
…arse (pythonGH-124233)

Only the first one has now been removed, all subsequent ones are now
taken literally.
(cherry picked from commit aae1267)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app

bedevere-app Bot commented Sep 20, 2024

Copy link
Copy Markdown

GH-124267 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Sep 20, 2024
@serhiy-storchaka serhiy-storchaka mentioned this pull request Sep 20, 2024
Closed
serhiy-storchaka added a commit that referenced this pull request Sep 20, 2024
@miss-islington @serhiy-storchaka
[3.12] gh-81691: Fix handling of multiple "--" (double dashes) in arg… …
6c6b044 
…parse (GH-124233) (GH-124267)

Only the first one has now been removed, all subsequent ones are now
taken literally.
(cherry picked from commit aae1267)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
savannahostrowski pushed a commit to savannahostrowski/cpython that referenced this pull request Sep 22, 2024
@serhiy-storchaka @savannahostrowski
pythongh-81691: Fix handling of multiple "--" (double dashes) in argp… …
a2e5f41 
…arse (pythonGH-124233)

Only the first one has now been removed, all subsequent ones are now
taken literally.
savannahostrowski pushed a commit to savannahostrowski/cpython that referenced this pull request Sep 22, 2024
@serhiy-storchaka @savannahostrowski
pythongh-81691: Fix handling of multiple "--" (double dashes) in argp… …
83f7d6d 
…arse (pythonGH-124233)

Only the first one has now been removed, all subsequent ones are now
taken literally.
serhiy-storchaka added a commit that referenced this pull request Oct 7, 2024
@miss-islington @serhiy-storchaka
[3.13] gh-81691: Fix handling of multiple "--" (double dashes) in arg… …
6387016 
…parse (GH-124233) (GH-124266)

Only the first one has now been removed, all subsequent ones are now
taken literally.
(cherry picked from commit aae1267)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@tacaswell tacaswell mentioned this pull request Oct 29, 2024
Closed
@ben-grande ben-grande mentioned this pull request Dec 3, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@serhiy-storchaka @savannahostrowski