{{ message }}
bpo-31904: fix test_utf8_mode fail issue on VxWorks#12428
Merged
vstinner merged 3 commits intoMar 27, 2019
Merged
Conversation
Contributor
Sorry, something went wrong.
VxWorks uses UTF-8 as the system encoding.
vstinner
requested changes
Mar 26, 2019
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Sorry, something went wrong.
Replace _vxworks with VXWORKS for VxWorks
vstinner
approved these changes
Mar 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
VxWorks uses UTF-8 as the system encoding. So the test case test_utf8_mode.py need to be updated to use UTF-8 on VxWorks.
https://bugs.python.org/issue31904