{{ message }}
gh-119180: Rename parameter to __annotate__ functions#124461
Closed
JelleZijlstra wants to merge 2 commits into
Closed
gh-119180: Rename parameter to __annotate__ functions#124461JelleZijlstra wants to merge 2 commits into
JelleZijlstra wants to merge 2 commits into
Conversation
Member
Sorry, something went wrong.
Larry Hastings pointed out that using an illegal parameter name makes it impossible to use inspect.signature() on annotate functions. Cross-ref python/peps#3993.
JelleZijlstra
requested review from
carljm,
iritkatriel and
markshannon
as code owners
September 24, 2024 18:57
30 tasks
iritkatriel
reviewed
Sep 24, 2024
carljm
approved these changes
Sep 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
Larry Hastings pointed out that using an illegal parameter name makes
it impossible to use inspect.signature() on annotate functions.
Cross-ref python/peps#3993.