◐ Shell
reader mode source ↗
Skip to content

bpo-36368: Ignore SIGINT in SharedMemoryManager servers.#12483

Merged
pitrou merged 11 commits into
python:masterfrom
pierreglaser:ignore-SIGINT-in-shared-memory-server
May 10, 2019
Merged

bpo-36368: Ignore SIGINT in SharedMemoryManager servers.#12483
pitrou merged 11 commits into
python:masterfrom
pierreglaser:ignore-SIGINT-in-shared-memory-server

Conversation

@pierreglaser

@pierreglaser pierreglaser commented Mar 21, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

When starting a SharedMemoryManager in an interactive session, any KeyboardInterrupt event will be transmitted to the (sub)process running the shared memory server, which causes the Manager to be unusable thereafter.

This PR catches SIGINT signals in server processes.

https://bugs.python.org/issue36368

@pierreglaser pierreglaser changed the title bpo-36338: Ignore SIGINT in SharedMemoryManager servers. Mar 21, 2019
@pierreglaser

pierreglaser commented Mar 22, 2019

Copy link
Copy Markdown
Contributor Author

FYI: I could not simulate a console CTRL-C event on windows in a test, so I skipped the test on Windows. I did test the fix locally on a Windows 10 VM in an interactive session, and it works.

jdemeyer
jdemeyer requested changes Mar 27, 2019
View reviewed changes

@jdemeyer jdemeyer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

See 2 comments

@brettcannon brettcannon added the type-bug An unexpected behavior, bug, or error label Mar 27, 2019
@pitrou

pitrou commented May 10, 2019

Copy link
Copy Markdown
Member

You may want to rebase/merge this. Also, feel free to ping when you need a core review :-)

@pierreglaser pierreglaser force-pushed the ignore-SIGINT-in-shared-memory-server branch from ec3cfdc to 01a1c0f Compare May 10, 2019 17:44
@pierreglaser

pierreglaser commented May 10, 2019

Copy link
Copy Markdown
Contributor Author

Rebased.

@pierreglaser pierreglaser mentioned this pull request May 10, 2019
Merged
pitrou
pitrou approved these changes May 10, 2019
View reviewed changes

@pitrou pitrou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM.

@pitrou pitrou merged commit d0d64ad into python:master May 10, 2019
@pierreglaser pierreglaser deleted the ignore-SIGINT-in-shared-memory-server branch May 10, 2019 18:43
@matrixise

matrixise commented May 15, 2019

Copy link
Copy Markdown
Member

@pierreglaser I think this merged PR was not for the right BPO.

https://bugs.python.org/issue36338 is "urlparse of urllib returns wrong hostname"

@pierreglaser

pierreglaser commented May 15, 2019

Copy link
Copy Markdown
Contributor Author

@matrixise sorry to hear that. The issue number looks correct though. Maybe I mistyped it when I opened the PR and quickly fixed it afterwards. Is there any way I can help fix that?

@matrixise

matrixise commented May 15, 2019

Copy link
Copy Markdown
Member

just take care for the next time ;-) I just wanted to check my tests with your PR for that BPO and the tests have failed ;-)

I think there is no fix for this issue because your PR has been merged into master.

Thanks again for your PR and your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitrou pitrou pitrou approved these changes

@jdemeyer jdemeyer jdemeyer approved these changes

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@pierreglaser @pitrou @matrixise @jdemeyer @brettcannon @the-knights-who-say-ni @bedevere-bot