◐ Shell
reader mode source ↗
Skip to content

gh-124960: Fixed barry_as_FLUFL future flag does not work in new REPL#124999

Merged
ambv merged 9 commits into
python:mainfrom
Wulian233:barry_as_FLUFL
Oct 14, 2024
Merged

gh-124960: Fixed barry_as_FLUFL future flag does not work in new REPL#124999
ambv merged 9 commits into
python:mainfrom
Wulian233:barry_as_FLUFL

Conversation

@Wulian233

@Wulian233 Wulian233 commented Oct 5, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

@bedevere-app bedevere-app Bot mentioned this pull request Oct 5, 2024
Closed
@Wulian233 Wulian233 marked this pull request as draft October 5, 2024 08:06
@nineteendo

nineteendo commented Oct 5, 2024

Copy link
Copy Markdown
Contributor

You can close this, I have a proper fix.

Wulian233 and others added 2 commits October 6, 2024 14:13
@Wulian233 @nineteendo
Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com> …
cc807ee 
Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
@Wulian233
LF
cf96285
@Wulian233

Wulian233 commented Oct 6, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

You can close this, I have a proper fix.

After my testing, your patch solved this bug. I added a co-author, but I need ask your opinion so that we can open one less PR

edit: tests fail.

@Wulian233 Wulian233 marked this pull request as ready for review October 6, 2024 06:27
Wulian233 and others added 2 commits October 9, 2024 06:41
@Wulian233 @nineteendo
Update Lib/_pyrepl/console.py …
2080b24 
Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
@ambv
Add tests, reformat a little
5dde260
@Wulian233 Wulian233 mentioned this pull request Oct 11, 2024
Closed
21 hidden items Load more…
@ambv ambv merged commit 6a08a75 into python:main Oct 14, 2024
@ambv ambv added the needs backport to 3.13 bugs and security fixes label Oct 14, 2024
@miss-islington-app

miss-islington-app Bot commented Oct 14, 2024

Copy link
Copy Markdown

Thanks @Wulian233 for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Oct 14, 2024

Copy link
Copy Markdown

Sorry, @Wulian233 and @ambv, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 6a08a753b702ac63c9b6ac58dd204d1fe9662e9d 3.13

@nineteendo nineteendo mentioned this pull request Oct 14, 2024
Merged
@bedevere-app

bedevere-app Bot commented Oct 14, 2024

Copy link
Copy Markdown

GH-125475 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Oct 14, 2024
nineteendo added a commit to nineteendo/cpython that referenced this pull request Oct 14, 2024
@Wulian233 @nineteendo @ambv
pythongh-124960: Fixed barry_as_FLUFL future flag does not work in … …
710d586 
…new REPL (python#124999)

Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
(cherry picked from commit 6a08a75)
ambv pushed a commit that referenced this pull request Oct 14, 2024
@nineteendo
[3.13] gh-124960: Fixed barry_as_FLUFL future flag does not work in… …
d54dbd6 
… new REPL (#124999) (#125475)

gh-124960: Fixed `barry_as_FLUFL` future flag does not work in new REPL (#124999)

Co-authored-by: Wulian <xiguawulian@gmail.com>
Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
(cherry picked from commit 6a08a75)
@Wulian233 Wulian233 deleted the barry_as_FLUFL branch October 14, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ambv ambv ambv left review comments

@sobolevn sobolevn sobolevn left review comments

@picnixz picnixz picnixz left review comments

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou

+1 more reviewer

@nineteendo nineteendo nineteendo left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@ambv ambv

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Wulian233 @nineteendo @ambv @sobolevn @picnixz