GH-125174: Make immortal objects more robust, following design from PEP 683#125251
GH-125174: Make immortal objects more robust, following design from PEP 683#125251markshannon merged 4 commits into
Conversation
|
This is not a complete fix for #125174, just enough to unblock other work |
Sorry, something went wrong.
|
🤖 New build scheduled with the buildbot fleet by @markshannon for commit 94f8fd0 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
Sorry, something went wrong.
|
The two "failing" refleak buildbots seem to be hanging in |
Sorry, something went wrong.
|
Performance impact: Overall a small slowdown, with a large 7-10% slowdown on nbody. I'll re-run the linux benchmarks with the fix as a sanity check. |
Sorry, something went wrong.
|
Windows shows an over 2% improvement. With the regression fixed, this I would expect this to be more than 3%. This reason for this is that the MSVC does not convert |
Sorry, something went wrong.
|
x86-64 linux performance numbers are a bit noisy, but show no significant change. |
Sorry, something went wrong.
python/cpython#125251 renamed _PY_IMMORTAL_REFCNT -> _PY_IMMORTAL_INITIAL_REFCNT
* MNT: account for CPython 314 changes python/cpython#125251 renamed _PY_IMMORTAL_REFCNT -> _PY_IMMORTAL_INITIAL_REFCNT * Define new macro to reduce duplication --------- Co-authored-by: Jim Crist-Harif <jcristharif@gmail.com>
edited by bedevere-app
Bot
LoadingUh oh!
There was an error while loading. Please reload this page.
Copy link Copy MarkdownSorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.