{{ message }}
gh-52551: Use wcsftime() to implement time.strftime() on Windows#125658
Merged
serhiy-storchaka merged 4 commits intoOct 19, 2024
Merged
gh-52551: Use wcsftime() to implement time.strftime() on Windows#125658serhiy-storchaka merged 4 commits into
serhiy-storchaka merged 4 commits into
Conversation
vstinner
reviewed
Oct 18, 2024
Member
Author
What exactly is that issue about? I get no mojibake: >>> import time
>>> time.strftime('%Z')
'Фінляндія (літо)'
>>> time.tzname
('Фінляндія (зима)', 'Фінляндія (літо)')But it crashes on invalid format string (like |
Sorry, something went wrong.
Member
Author
Well, this was unrelated. |
Sorry, something went wrong.
Member
I changed my Windows language to French and the timezone to UTC+14, I managed to get a non-ASCII timezone name: So at least for this locale (French_France.1252), it works as expected. |
Sorry, something went wrong.
vstinner
approved these changes
Oct 18, 2024
vstinner
left a comment
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
edited by bedevere-app
Bot
LoadingUh oh!
There was an error while loading. Please reload this page.
Copy link Copy MarkdownSorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.