◐ Shell
reader mode source ↗
Skip to content

bpo-31341: cleanup IRIX-specific macros sgi and __sgi#12587

Closed
yan12125 wants to merge 1 commit into
python:mainfrom
yan12125:sgi-irix-cleanup
Closed

bpo-31341: cleanup IRIX-specific macros sgi and __sgi#12587
yan12125 wants to merge 1 commit into
python:mainfrom
yan12125:sgi-irix-cleanup

Conversation

@yan12125

@yan12125 yan12125 commented Mar 27, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown

To make work on curses-related modules simpler https://bugs.python.org/issue28190

https://bugs.python.org/issue31341

benjaminp
benjaminp requested changes Sep 11, 2019
View reviewed changes

@benjaminp benjaminp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

This looks mostly good but needs a rebase.

@bedevere-bot

bedevere-bot commented Sep 11, 2019

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@yan12125

yan12125 commented Sep 15, 2019

Copy link
Copy Markdown
Author

I have made the requested changes; please review again.

As a side note, the merge conflict was due to additions for VxWorks (https://github.com/python/cpython/pull/12118/files#diff-a6f29e907cbb5fffd44d453bcd7b77d5R232).

@bedevere-bot

bedevere-bot commented Sep 15, 2019

Copy link
Copy Markdown

Thanks for making the requested changes!

@benjaminp: please review the changes made to this pull request.

@yan12125 yan12125 changed the title bpo-31341: remove more SGI IRIX-specific codes Feb 20, 2021
@yan12125

yan12125 commented Feb 20, 2021

Copy link
Copy Markdown
Author

Most IRIX-specific codes are removed in #23023, while there are still references to IRIX-specific macros sgi and __sgi. I rebased this pull request to only remove remaining macros.

@yan12125

yan12125 commented Nov 12, 2021

Copy link
Copy Markdown
Author

Rebased for recent cleanups in Include/Python.h (https://bugs.python.org/issue45434)

@yan12125

yan12125 commented Mar 14, 2022

Copy link
Copy Markdown
Author

Seems no sign of further reviewing, closing.

@yan12125 yan12125 closed this Mar 14, 2022
@yan12125 yan12125 deleted the sgi-irix-cleanup branch March 14, 2022 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjaminp benjaminp Awaiting requested review from benjaminp

Assignees

No one assigned

Labels

awaiting change review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yan12125 @bedevere-bot @benjaminp @the-knights-who-say-ni