gh-125206: Correct detection of complex numbers support in libffi#126104
gh-125206: Correct detection of complex numbers support in libffi#126104vstinner merged 7 commits into
Conversation
|
!buildbot SPARCv9 Oracle Solaris 11.4 |
Sorry, something went wrong.
|
🤖 New build scheduled with the buildbot fleet by @skirpichev for commit 66c1cf7 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
!buildbot PPC64LE CentOS9 LTO + PGO |
Sorry, something went wrong.
|
🤖 New build scheduled with the buildbot fleet by @skirpichev for commit 66c1cf7 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
Sorry, something went wrong.
|
PPC64LE build works as expected (no support) |
Sorry, something went wrong.
|
!buildbot SPARCv9 Oracle Solaris 11.4 |
Sorry, something went wrong.
|
🤖 New build scheduled with the buildbot fleet by @skirpichev for commit fc4ebff 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
Sorry, something went wrong.
|
Hmm, now on SPARCv9 - libffi support was detected. Test failures seems unrelated and build was successful. (C.f. https://buildbot.python.org/all/#/builders/1262/builds/13 and https://buildbot.python.org/#/builders/1262/builds/21) |
Sorry, something went wrong.
vstinner
left a comment
There was a problem hiding this comment.
@efimov-mikhail: Can you test the fix on Debian 10?
Sorry, something went wrong.
|
I don't expect something new, as on his local system patch was working: #125322 (comment) (test code was unchanged) |
Sorry, something went wrong.
Yes, I can. It looks like the correct fix, but it's better to test again. |
Sorry, something went wrong.
|
This fix works fine on Debian 10. |
Sorry, something went wrong.
erlend-aasland
left a comment
There was a problem hiding this comment.
LGTM (if the Sparc failure is unrelated).
Sorry, something went wrong.
|
Merged, thanks.
There are tons of unrelated errors/test failures on Solaris. |
Sorry, something went wrong.
|
On SPARCv9 only configure test was checked. It reports "yes" (supported). But it seems that ctypes tests weren't run. Sadly that configure script doesn't report library versions (even if this is available e.g. with |
Sorry, something went wrong.
We could fix that if we wanted. |
Sorry, something went wrong.
If that does make sense, I can open an issue. But I admit, that I don't know how to solve this in general: maybe every snowflake^Wlibrary will require a special treatment. BTW, version information is unavailable in the config.log (even for versioned checks like for libmpdec). |
Sorry, something went wrong.
|
IIRC (from the top of my head), the pkg-config macro will print version information if you specify version bounds (see the sqlite3 third-party detection code in |
Sorry, something went wrong.
Quick test for mpdec (which uses same PKG_CHECK_MODULES macro for system libmpdec, just as for sqlite3) shows, that it's not true: |
Sorry, something went wrong.
edited by bedevere-app
Bot
LoadingUh oh!
There was an error while loading. Please reload this page.
Copy link Copy MarkdownSorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.