◐ Shell
reader mode source ↗
Skip to content

bpo-31904: Fix file not exist error string#12646

Merged
vstinner merged 3 commits into
python:masterfrom
Wind-River:fix-file-not-exist
Apr 17, 2019
Merged

bpo-31904: Fix file not exist error string#12646
vstinner merged 3 commits into
python:masterfrom
Wind-River:fix-file-not-exist

Conversation

@LihuaZhao

@LihuaZhao LihuaZhao commented Apr 1, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

The strerror return "no such file or directory" when error code is ENOENT on VxWorks, this is different from Linux, change test_tabnanny.py toVxWorks excpected string.

https://bugs.python.org/issue31904

LihuaZhao added 2 commits April 1, 2019 16:04
@LihuaZhao
bpo-31904: handle error string of ENOENT for VxWorks …
40d11c8 
The strerror return "no such file or directory" when error code is
ENOENT on VxWorks, this is different from Linux, change test_tabnanny.py
toVxWorks excpected string.
@LihuaZhao
add news file
ecb3305
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Apr 1, 2019
@LihuaZhao LihuaZhao changed the title Fix file not exist Apr 1, 2019
@LihuaZhao

LihuaZhao commented Apr 1, 2019

Copy link
Copy Markdown
Contributor Author

The buildbot failure doesn't matter with test_tabnanny, which already pass.

Thanks.
Lihua

@LihuaZhao LihuaZhao closed this Apr 4, 2019
@LihuaZhao LihuaZhao reopened this Apr 4, 2019
@bedevere-bot

bedevere-bot commented Apr 16, 2019

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@LihuaZhao

LihuaZhao commented Apr 17, 2019

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again.

@bedevere-bot

bedevere-bot commented Apr 17, 2019

Copy link
Copy Markdown

Thanks for making the requested changes!

@vstinner: please review the changes made to this pull request.

@vstinner vstinner merged commit 36c41bc into python:master Apr 17, 2019
@vstinner

vstinner commented Apr 17, 2019

Copy link
Copy Markdown
Member

Thanks @LihuaZhao: the change now makes the test better on all platforms, rather than introducing code specific to VxWorks! :-)

@pxinwr pxinwr deleted the fix-file-not-exist branch July 12, 2021 09:42
@kuhlenough kuhlenough mannequin mentioned this pull request Jan 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LihuaZhao @bedevere-bot @vstinner @the-knights-who-say-ni