◐ Shell
reader mode source ↗
Skip to content

bpo-31904 : skip test_cmd_line case for VxWorks doesn't support preexec#12648

Merged
vstinner merged 6 commits into
python:masterfrom
Wind-River:fix-skip-cmd-line
Apr 17, 2019
Merged

bpo-31904 : skip test_cmd_line case for VxWorks doesn't support preexec#12648
vstinner merged 6 commits into
python:masterfrom
Wind-River:fix-skip-cmd-line

Conversation

@LihuaZhao

@LihuaZhao LihuaZhao commented Apr 1, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

subprocess.Popen doesn't support preexec on VxWorks, test_cmd_line need to skip the case which use preexec

https://bugs.python.org/issue31904

LihuaZhao added 2 commits April 1, 2019 17:43
@LihuaZhao
bpo-31904: skip some test case in test_cmd_line for VxWorks doesn't …
e64be8c 
support preexec

subprocess.Popen doesn't support preexec, test_cmd_line need to skip the
case which use preexec
@LihuaZhao
add news file
3762b12
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Apr 1, 2019
@LihuaZhao LihuaZhao closed this Apr 4, 2019
@LihuaZhao LihuaZhao reopened this Apr 4, 2019
@bedevere-bot

bedevere-bot commented Apr 17, 2019

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@LihuaZhao

LihuaZhao commented Apr 17, 2019

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again.

@bedevere-bot

bedevere-bot commented Apr 17, 2019

Copy link
Copy Markdown

Thanks for making the requested changes!

@vstinner: please review the changes made to this pull request.

@bedevere-bot

bedevere-bot commented Apr 17, 2019

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be poked with soft cushions!

@LihuaZhao

LihuaZhao commented Apr 17, 2019

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again.

@bedevere-bot

bedevere-bot commented Apr 17, 2019

Copy link
Copy Markdown

Thanks for making the requested changes!

@vstinner: please review the changes made to this pull request.

@vstinner vstinner merged commit 2954550 into python:master Apr 17, 2019
@bedevere-bot

bedevere-bot commented Apr 17, 2019

Copy link
Copy Markdown

@vstinner: Please replace # with GH- in the commit message next time. Thanks!

@LihuaZhao LihuaZhao changed the title bpo-31904: skip test_cmd_line case for VxWorks doesn't support preexec Apr 17, 2019
@LihuaZhao LihuaZhao changed the title bpo-36648 : skip test_cmd_line case for VxWorks doesn't support preexec Apr 17, 2019
@asvetlov asvetlov changed the title bpo-31094 : skip test_cmd_line case for VxWorks doesn't support preexec Apr 17, 2019
@pxinwr pxinwr deleted the fix-skip-cmd-line branch July 12, 2021 09:42
@kuhlenough kuhlenough mannequin mentioned this pull request Jan 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LihuaZhao @bedevere-bot @vstinner @the-knights-who-say-ni