◐ Shell
reader mode source ↗
Skip to content

[3.13] gh-126699: allow AsyncIterator to be used as a base for Protocols (GH-126702)#126762

Merged
Yhg1s merged 1 commit into
python:3.13from
miss-islington:backport-feb3e0b-3.13
Dec 2, 2024
Merged

[3.13] gh-126699: allow AsyncIterator to be used as a base for Protocols (GH-126702)#126762
Yhg1s merged 1 commit into
python:3.13from
miss-islington:backport-feb3e0b-3.13

Conversation

@miss-islington

@miss-islington miss-islington commented Nov 12, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

(cherry picked from commit feb3e0b)

Co-authored-by: Stephen Morton github@tungol.org

@tungol @miss-islington
pythongh-126699: allow AsyncIterator to be used as a base for Protoco… …
0e45a7a 
…ls (pythonGH-126702)

(cherry picked from commit feb3e0b)

Co-authored-by: Stephen Morton <github@tungol.org>
This was referenced Nov 12, 2024
Merged
Closed
@gpshead

gpshead commented Nov 13, 2024

Copy link
Copy Markdown
Member

This needs clear documentation as to the version constraints so that anyone attempting to rely on it knows specifically when it stopped working and in which patch releases it started working.

While its removal was a bug, this is also something that people can't reliably depend on in Python by simply knowing the major version if you backport it to 3.12 and 3.13...

@AlexWaygood

AlexWaygood commented Nov 13, 2024

Copy link
Copy Markdown
Member

This needs clear documentation as to the version constraints so that anyone attempting to rely on it knows specifically when it stopped working and in which patch releases it started working.

While its removal was a bug, this is also something that people can't reliably depend on in Python by simply knowing the major version if you backport it to 3.12 and 3.13...

I'm not sure I agree. I feel like by the same logic, we'd never backport any bugfixes?

Using multiple inheritance with typing.Protocol and collections.abc.AsyncIterator currently raises an exception at runtime on Python 3.13, which is a bug. This change fixes that bug so that an exception is no longer raised. We don't typically go to great lengths in our docs to state when bugs like this were fixed, do we?

@Yhg1s

Yhg1s commented Dec 2, 2024

Copy link
Copy Markdown
Member

I agree with Alex, I think this is just a plain bugfix.

@Yhg1s Yhg1s merged commit a5672be into python:3.13 Dec 2, 2024
@miss-islington miss-islington deleted the backport-feb3e0b-3.13 branch January 2, 2026 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@miss-islington @gpshead @AlexWaygood @Yhg1s @tungol