◐ Shell
reader mode source ↗
Skip to content

bpo-30156: Fix a crash in debug build when PYTHONDUMPREFS is set.#1272

Closed
serhiy-storchaka wants to merge 4 commits into
python:masterfrom
serhiy-storchaka:property-cached-args-set-size-0
Closed

bpo-30156: Fix a crash in debug build when PYTHONDUMPREFS is set.#1272
serhiy-storchaka wants to merge 4 commits into
python:masterfrom
serhiy-storchaka:property-cached-args-set-size-0

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Apr 24, 2017

Copy link
Copy Markdown
Member

Apply an alternate patch from bpo-26811.

https://bugs.python.org/issue30156

@mention-bot

Copy link
Copy Markdown

@serhiy-storchaka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @tim-one, @benjaminp and @tiran to be potential reviewers.

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

See discussion on the issue.

@serhiy-storchaka

Copy link
Copy Markdown
Member Author

Excuse me, @Haypo, I have not understood what changes did you request.

@vstinner

Copy link
Copy Markdown
Member

"See discussion on the issue." means see my comment on the issue: http://bugs.python.org/issue30156#msg292239 Basically, I asked if the optimization is worth it.

@brettcannon

Copy link
Copy Markdown
Member

To try and help move older pull requests forward, we are going through and backfilling 'awaiting' labels on pull requests that are lacking the label. Based on the current reviews, the best we can tell in an automated fashion is that a core developer requested changes to be made to this pull request.

If/when the requested changes have been made, please leave a comment that says, I have made the requested changes; please review again. That will trigger a bot to flag this pull request as ready for a follow-up review.

@vstinner

vstinner commented Oct 1, 2018

Copy link
Copy Markdown
Member

I removed the optimization instead: PR #9541.

@vstinner vstinner closed this Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting changes type-bug An unexpected behavior, bug, or error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants