{{ message }}
bpo-36577: setup.py reports missing OpenSSL again#12746
Merged
miss-islington merged 1 commit intoApr 9, 2019
Merged
Conversation
Member
Sorry, something went wrong.
bpo-36146 introduced another regression. In case of missing OpenSSL libraries or headers, setup.py no longer reported _hashlib and _ssl to be missing. Signed-off-by: Christian Heimes <christian@python.org>
tiran
force-pushed
the
bpo-36577-setup-ssl
branch
from
ac404df to
d2f50f5
Compare
April 9, 2019 15:37
Member
Author
|
@xdegaye This is another regression. I found while I was verifying your PR. Thanks again! |
Sorry, something went wrong.
Member
Sorry, something went wrong.
vstinner
approved these changes
Apr 9, 2019
vstinner
left a comment
vstinner
left a comment
Member
There was a problem hiding this comment.
LGTM.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
bpo-36146 introduced another regression. In case of missing OpenSSL
libraries or headers, setup.py no longer reported _hashlib and _ssl to
be missing.
Signed-off-by: Christian Heimes christian@python.org
https://bugs.python.org/issue36577