◐ Shell
reader mode source ↗
Skip to content

gh-118915: C API: Document frame locals proxies.#127720

Merged
vstinner merged 5 commits into
python:mainfrom
ZeroIntensity:document-framelocalsproxy
Dec 11, 2024
Merged

gh-118915: C API: Document frame locals proxies.#127720
vstinner merged 5 commits into
python:mainfrom
ZeroIntensity:document-framelocalsproxy

Conversation

@ZeroIntensity

@ZeroIntensity ZeroIntensity commented Dec 7, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

@ZeroIntensity ZeroIntensity added docs Documentation in the Doc dir skip news topic-C-API needs backport to 3.13 bugs and security fixes labels Dec 7, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Dec 7, 2024
Open
78 tasks
@gaogaotiantian

gaogaotiantian commented Dec 8, 2024

Copy link
Copy Markdown
Member

Overall I think it's okay, but I'm not the expert in docs. @ncoghlan would fit better in this role. Also maybe someone who's familiar with the docs like @AlexWaygood.

@AlexWaygood AlexWaygood self-requested a review December 8, 2024 20:09
AlexWaygood
AlexWaygood reviewed Dec 9, 2024
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thanks!

@ZeroIntensity @AlexWaygood
Update frame.rst …
8ec995f 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@bedevere-app bedevere-app Bot added and removed awaiting core review labels Dec 9, 2024
@vstinner vstinner merged commit dd9da73 into python:main Dec 11, 2024
@miss-islington-app

miss-islington-app Bot commented Dec 11, 2024

Copy link
Copy Markdown

Thanks @ZeroIntensity for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 11, 2024
@ZeroIntensity @AlexWaygood @miss-islington
pythongh-118915: C API: Document frame locals proxies. (pythonGH-127720) …
f86cf73 
(cherry picked from commit dd9da73)

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@bedevere-app

bedevere-app Bot commented Dec 11, 2024

Copy link
Copy Markdown

GH-127831 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Dec 11, 2024
@vstinner

vstinner commented Dec 11, 2024

Copy link
Copy Markdown
Member

Merged, thanks.

vstinner pushed a commit that referenced this pull request Dec 11, 2024
@miss-islington @ZeroIntensity @AlexWaygood
[3.13] gh-118915: C API: Document frame locals proxies. (GH-127720) (#… …
8b24d04 
…127831)

gh-118915: C API: Document frame locals proxies. (GH-127720)
(cherry picked from commit dd9da73)

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@ZeroIntensity ZeroIntensity deleted the document-framelocalsproxy branch December 11, 2024 16:49
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@ZeroIntensity @AlexWaygood @srinivasreddy
pythongh-118915: C API: Document frame locals proxies. (python#127720) …
606869b 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz

@vstinner vstinner vstinner approved these changes

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@StanFromIreland StanFromIreland

@markshannon markshannon Awaiting requested review from markshannon

@gaogaotiantian gaogaotiantian Awaiting requested review from gaogaotiantian

+1 more reviewer

@rruuaanng rruuaanng rruuaanng left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news topic-C-API

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ZeroIntensity @gaogaotiantian @vstinner @picnixz @AlexWaygood @StanFromIreland @rruuaanng