◐ Shell
reader mode source ↗
Skip to content

gh-128116: Skip test_socket VSOCK testStream() on PermissionError#128120

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:vsock_eperm
Dec 20, 2024
Merged

gh-128116: Skip test_socket VSOCK testStream() on PermissionError#128120
vstinner merged 1 commit into
python:mainfrom
vstinner:vsock_eperm

Conversation

@vstinner

@vstinner vstinner commented Dec 20, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Dec 20, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Dec 20, 2024
Closed
@vstinner vstinner added the bugs and security fixes label Dec 20, 2024
@vstinner

vstinner commented Dec 20, 2024

Copy link
Copy Markdown
Member Author

!buildbot PPC64LE Fedora Stable PR

@bedevere-bot

bedevere-bot commented Dec 20, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @vstinner for commit e587ce5 🤖

The command will test the builders whose names match following regular expression: PPC64LE Fedora Stable PR

The builders matched are:

  • PPC64LE Fedora Stable PR

@vstinner

vstinner commented Dec 20, 2024

Copy link
Copy Markdown
Member Author

I only found two lines in Linux net/vmw_vsock/ using EACCES, both in "bind" operations:

Example:

	if (port <= LAST_RESERVED_PORT && !capable(CAP_NET_BIND_SERVICE))
		return -EACCES;

But the Python test uses port 1234 which is greater than LAST_RESERVED_PORT (1023).

@vstinner vstinner merged commit cbfe302 into python:main Dec 20, 2024
@miss-islington-app

miss-islington-app Bot commented Dec 20, 2024

Copy link
Copy Markdown

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@vstinner vstinner deleted the vsock_eperm branch December 20, 2024 12:38
@bedevere-app

bedevere-app Bot commented Dec 20, 2024

Copy link
Copy Markdown

GH-128123 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Dec 20, 2024
@vstinner vstinner added the needs backport to 3.12 only security fixes label Dec 20, 2024
@miss-islington-app

miss-islington-app Bot commented Dec 20, 2024

Copy link
Copy Markdown

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 20, 2024
@vstinner @miss-islington
pythongh-128116: Skip test_socket VSOCK testStream() on PermissionErr… …
19dc605 
…or (pythonGH-128120)

(cherry picked from commit cbfe302)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app

bedevere-app Bot commented Dec 20, 2024

Copy link
Copy Markdown

GH-128124 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Dec 20, 2024
vstinner added a commit that referenced this pull request Dec 20, 2024
@miss-islington @vstinner
[3.13] gh-128116: Skip test_socket VSOCK testStream() on PermissionEr… …
43586a4 
…ror (GH-128120) (#128123)

gh-128116: Skip test_socket VSOCK testStream() on PermissionError (GH-128120)
(cherry picked from commit cbfe302)

Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner added a commit that referenced this pull request Dec 20, 2024
@miss-islington @vstinner
[3.12] gh-128116: Skip test_socket VSOCK testStream() on PermissionEr… …
23e8fc2 
…ror (GH-128120) (#128124)

gh-128116: Skip test_socket VSOCK testStream() on PermissionError (GH-128120)
(cherry picked from commit cbfe302)

Co-authored-by: Victor Stinner <vstinner@python.org>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Dec 23, 2024
@vstinner @srinivasreddy
pythongh-128116: Skip test_socket VSOCK testStream() on PermissionErr… …
e803dea 
…or (python#128120)
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@vstinner @srinivasreddy
pythongh-128116: Skip test_socket VSOCK testStream() on PermissionErr… …
47a6a27 
…or (python#128120)
@vstinner vstinner mentioned this pull request Jan 22, 2025
Merged
vstinner added a commit to vstinner/cpython that referenced this pull request Jan 22, 2025
@vstinner
pythongh-128116: Skip test_socket VSOCK testStream() on PermissionErr… …
bc8b07d 
…or (python#128120)

(cherry picked from commit cbfe302)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vstinner @bedevere-bot