{{ message }}
bpo-36616: optimize handling of thread state in function call code#12839
Closed
jdemeyer wants to merge 1 commit into
Closed
bpo-36616: optimize handling of thread state in function call code#12839jdemeyer wants to merge 1 commit into
jdemeyer wants to merge 1 commit into
Conversation
Contributor
Sorry, something went wrong.
Thanks to Mark Shannon for the idea
scoder
reviewed
Apr 15, 2019
scoder
left a comment
scoder
left a comment
Contributor
There was a problem hiding this comment.
I'd say, why not, but would also like to see at least some timings.
Sorry, something went wrong.
Contributor
Author
|
I did some more extensive benchmarks today and I'm no longer convinced that this actually improves anything. In any case, the gain would be very close to the measurement error and not significant. Parts of this could still make sense as a "clean up" patch, for example the strange assignment of |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
Thanks to @markshannon for the idea.
This does various micro-optimizations for function calls in the bytecode interpreter to give a small increase in performance.
https://bugs.python.org/issue36616