◐ Shell
reader mode source ↗
Skip to content

gh-59022: add tests to extend_path#12871

Closed
Windsooon wants to merge 6 commits into
python:mainfrom
Windsooon:bpo-14817
Closed

gh-59022: add tests to extend_path#12871
Windsooon wants to merge 6 commits into
python:mainfrom
Windsooon:bpo-14817

Conversation

@Windsooon

@Windsooon Windsooon commented Apr 18, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Actually, there are some tests for extend_path already (see https://github.com/python/cpython/blob/master/Lib/test/test_pkgutil.py#L235). I add some tests for it anyway. However, I didn't test every line of the code in the extend_path function.

https://bugs.python.org/issue14817

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Apr 18, 2019
@nanjekyejoannah

nanjekyejoannah commented Jul 9, 2019

Copy link
Copy Markdown
Contributor

cc @ericvsmith

@arhadthedev arhadthedev changed the title bpo-14817: add tests to extend_path Feb 5, 2023
@arhadthedev

arhadthedev commented Feb 5, 2023

Copy link
Copy Markdown
Member

Would anybody mind to review and possibly merge this PR?

@arhadthedev

arhadthedev commented Apr 9, 2023

Copy link
Copy Markdown
Member

@vsajip, @brettcannon, could you review and possibly merge this PR, please? (as the ones who committed into Lib/test/test_pkgutil.py more than once last ten years and still active)

@brettcannon

brettcannon commented Apr 12, 2023

Copy link
Copy Markdown
Member

I'm rather swamped right now, so it might be a while (especially since I want to deprecate the entire pkgutil module eventually 😁).

@brettcannon brettcannon self-requested a review April 12, 2023 18:31
brettcannon
brettcannon requested changes Jun 9, 2023
View reviewed changes

@brettcannon brettcannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

The tests have some misleading names and they are not cleaning up after themselves appropriately.

@bedevere-bot

bedevere-bot commented Jun 9, 2023

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@erlend-aasland erlend-aasland added the pending The issue will be closed if no feedback is provided label Feb 9, 2024
@nineteendo

nineteendo commented May 18, 2024

Copy link
Copy Markdown
Contributor

Do we close this or do we remove the pending label? It's been almost 100 days.

@ericvsmith

ericvsmith commented May 19, 2024

Copy link
Copy Markdown
Member

Closing due to inactivity.

@ericvsmith ericvsmith closed this May 19, 2024
@beachmachine beachmachine mentioned this pull request Jul 13, 2024
Merged
@bedevere-app bedevere-app Bot mentioned this pull request Jul 13, 2024
Closed
@AA-Turner AA-Turner removed the pending The issue will be closed if no feedback is provided label Apr 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon requested changes

@furkanonder furkanonder furkanonder approved these changes

+1 more reviewer

@auvipy auvipy auvipy approved these changes

Assignees

No one assigned

Labels

awaiting changes skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.