◐ Shell
reader mode source ↗
Skip to content

gh-129033: Remove _PyInterpreterState_SetConfig() function#129048

Merged
vstinner merged 2 commits into
python:mainfrom
vstinner:remove_set_config
Jan 20, 2025
Merged

gh-129033: Remove _PyInterpreterState_SetConfig() function#129048
vstinner merged 2 commits into
python:mainfrom
vstinner:remove_set_config

Conversation

@vstinner

@vstinner vstinner commented Jan 20, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Remove _PyInterpreterState_GetConfigCopy() and
_PyInterpreterState_SetConfig() private functions. PEP 741 "Python Configuration C API" added a better public C API: PyConfig_Get() and PyConfig_Set().

@bedevere-app bedevere-app Bot mentioned this pull request Jan 20, 2025
Closed
@vstinner vstinner requested a review from markshannon as a code owner January 20, 2025 11:43
@vstinner
pythongh-129033: Remove _PyInterpreterState_SetConfig() function …
27ebb23 
Remove _PyInterpreterState_GetConfigCopy() and
_PyInterpreterState_SetConfig() private functions. PEP 741 "Python
Configuration C API" added a better public C API: PyConfig_Get() and
PyConfig_Set().
@vstinner

vstinner commented Jan 20, 2025

Copy link
Copy Markdown
Member Author

I got impacted by #129060 issue. I rebased my PR on top of it to fix the issue.

@vstinner

vstinner commented Jan 20, 2025

Copy link
Copy Markdown
Member Author

Oh, test_py_config_isoloated_per_interpreter() of test_capi.test_misc fails with in Free Threaded build:

ImportError: module _testcapi does not support loading in subinterpreters

@vstinner vstinner merged commit 8ceb6cb into python:main Jan 20, 2025
@vstinner vstinner deleted the remove_set_config branch January 20, 2025 15:31
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 21, 2025
@vstinner @srinivasreddy
pythongh-129033: Remove _PyInterpreterState_SetConfig() function (pyt… …
25cfc81 
…hon#129048)

Remove _PyInterpreterState_GetConfigCopy() and
_PyInterpreterState_SetConfig() private functions. PEP 741 "Python
Configuration C API" added a better public C API: PyConfig_Get() and
PyConfig_Set().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently is a code owner

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

1 more reviewer

@youknowone youknowone youknowone left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vstinner @youknowone