◐ Shell
reader mode source ↗
Skip to content

gh-111178: fix UBSan failures in Modules/_ctypes#129071

Merged
picnixz merged 13 commits into
python:mainfrom
picnixz:fix/ubsan/ctypes-111178
Jan 21, 2025
Merged

gh-111178: fix UBSan failures in Modules/_ctypes#129071
picnixz merged 13 commits into
python:mainfrom
picnixz:fix/ubsan/ctypes-111178

Conversation

@picnixz

@picnixz picnixz commented Jan 20, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-app bedevere-app Bot mentioned this pull request Jan 20, 2025
Closed
encukou
encukou reviewed Jan 20, 2025
View reviewed changes

@encukou encukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Looks good!

encukou
encukou approved these changes Jan 20, 2025
View reviewed changes

@encukou encukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM!
Don't worry about making it any prettier.

@picnixz

picnixz commented Jan 20, 2025

Copy link
Copy Markdown
Member Author

@vstinner I plan to merge this one with no commit message and the PR's title as the commit's title.

vstinner
vstinner approved these changes Jan 20, 2025
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

The code changes LGTM. I didn't test the change.

@picnixz picnixz merged commit fafc618 into python:main Jan 21, 2025
@picnixz picnixz deleted the fix/ubsan/ctypes-111178 branch January 21, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroIntensity ZeroIntensity ZeroIntensity left review comments

@vstinner vstinner vstinner approved these changes

@encukou encukou encukou approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@picnixz @vstinner @encukou @ZeroIntensity