◐ Shell
reader mode source ↗
Skip to content

Improve tests for _colorize.can_colorize()#129234

Merged
hugovk merged 5 commits into
python:mainfrom
serhiy-storchaka:test__colorize
Jan 24, 2025
Merged

Improve tests for _colorize.can_colorize()#129234
hugovk merged 5 commits into
python:mainfrom
serhiy-storchaka:test__colorize

Conversation

@serhiy-storchaka

Copy link
Copy Markdown
Member

No description provided.

@serhiy-storchaka serhiy-storchaka marked this pull request as ready for review January 23, 2025 18:24

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thanks, looks good.

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@hugovk hugovk merged commit 7907203 into python:main Jan 24, 2025
@miss-islington-app

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@hugovk

hugovk commented Jan 24, 2025

Copy link
Copy Markdown
Member

Thanks!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 24, 2025
(cherry picked from commit 7907203)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app

bedevere-app Bot commented Jan 24, 2025

Copy link
Copy Markdown

GH-129265 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jan 24, 2025
serhiy-storchaka added a commit that referenced this pull request Jan 24, 2025
)

(cherry picked from commit 7907203)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip issue skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants