◐ Shell
reader mode source ↗
Skip to content

gh-91048: fix thread safety for asyncio stack introspection APIs#129399

Merged
kumaraditya303 merged 2 commits into
python:mainfrom
kumaraditya303:tsafe
Feb 6, 2025
Merged

gh-91048: fix thread safety for asyncio stack introspection APIs#129399
kumaraditya303 merged 2 commits into
python:mainfrom
kumaraditya303:tsafe

Conversation

@kumaraditya303

@kumaraditya303 kumaraditya303 commented Jan 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Changes:

  • Add critical sections where required before calling impl function
  • Add critical section assertions
  • Move getters setters to be together with others
  • Elide away unnecessary type checks and align functions to take FutureObj * as all the other ones already do. In most cases, we avoid type checking on task which is guaranteed to be task or its subclass.

@bedevere-app bedevere-app Bot added the label Jan 28, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jan 28, 2025
Closed
@kumaraditya303

kumaraditya303 commented Feb 6, 2025

Copy link
Copy Markdown
Contributor Author

Merging this as its been sitting idle for over a week now.

@kumaraditya303 kumaraditya303 merged commit 75c5519 into python:main Feb 6, 2025
@kumaraditya303 kumaraditya303 deleted the tsafe branch February 6, 2025 16:04
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Feb 7, 2025
@kumaraditya303 @srinivasreddy
pythongh-91048: fix thread safety for asyncio stack introspection APIs ( …
c6650de 
python#129399)
cmaloney pushed a commit to cmaloney/cpython that referenced this pull request Feb 8, 2025
@kumaraditya303 @cmaloney
pythongh-91048: fix thread safety for asyncio stack introspection APIs ( …
63d3c3c 
python#129399)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

@ambv ambv Awaiting requested review from ambv

@pablogsal pablogsal Awaiting requested review from pablogsal

Assignees

No one assigned

Labels

skip news topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kumaraditya303