◐ Shell
reader mode source ↗
Skip to content

gh-93649: Split _testcapimodule.c into smaller files#129400

Closed
vstinner wants to merge 1 commit into
python:mainfrom
vstinner:split_testcapi
Closed

gh-93649: Split _testcapimodule.c into smaller files#129400
vstinner wants to merge 1 commit into
python:mainfrom
vstinner:split_testcapi

Conversation

@vstinner

@vstinner vstinner commented Jan 28, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

  • Move many functions from _testcapimodule.c into more specific files in Modules/_testcapi/.

  • Add files:

    • Modules/_testcapi/frame.c
    • Modules/_testcapi/function.c
    • Modules/_testcapi/type.c

  • In moved code:

    • Replace get_testerror() with PyExc_AssertionError.
    • Replace raiseTestError() with PyErr_Format(PyExc_AssertionError, ...).

@bedevere-app bedevere-app Bot mentioned this pull request Jan 28, 2025
Open
@vstinner
pythongh-93649: Split _testcapimodule.c into smaller files …
78d4204 
* Move many functions from _testcapimodule.c into more specific files
  in Modules/_testcapi/.

* Add files:

  * Modules/_testcapi/frame.c
  * Modules/_testcapi/function.c
  * Modules/_testcapi/type.c

* In moved code:

  * Replace get_testerror() with PyExc_AssertionError.
  * Replace raiseTestError() with
    PyErr_Format(PyExc_AssertionError, ...).
@vstinner vstinner marked this pull request as draft January 31, 2025 13:11
@vstinner

vstinner commented Feb 1, 2025

Copy link
Copy Markdown
Member Author

I have split this PR into smaller PRs:

@vstinner vstinner closed this Feb 1, 2025
@vstinner vstinner deleted the split_testcapi branch February 1, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner will be requested when the pull request is marked ready for review AA-Turner is a code owner

@emmatyping emmatyping Awaiting requested review from emmatyping emmatyping will be requested when the pull request is marked ready for review

@itamaro itamaro Awaiting requested review from itamaro itamaro will be requested when the pull request is marked ready for review itamaro is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@vstinner