{{ message }}
bpo-36722: Style and grammar edits for ABI entry#12979
Merged
vstinner merged 1 commit intoApr 27, 2019
Merged
Conversation
Member
Sorry, something went wrong.
vstinner
reviewed
Apr 27, 2019
vstinner
left a comment
vstinner
left a comment
Member
There was a problem hiding this comment.
Oh, I am using the "define" term whereas you are right: I should use the "macro" term.
Would you mind to check if Misc/SpecialBuilds.txt uses the right term?
And maybe also update the NEWS entries of the 3 issues?
Sorry, something went wrong.
pganssle
force-pushed
the
cleanup-abi-whatsnew
branch
from
f729a0c to
e63b60e
Compare
April 27, 2019 16:49
Member
Author
|
@vstinner Updated. I went with "preprocessor directives" in the |
Sorry, something went wrong.
Member
|
Thanks Paul! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
@vstinner expedited the merge for this ABI entry to make sure it's in before the alpha4 release. This is a cleanup PR with my copy edits.
The one thing I wasn't sure about is that I changed the word "define" to "macro" in a few places, referring to preprocessor directives like
Py_TRACE_REFS. Macro sounds more right to me than "define", though I did always think there was a qualitative difference between expansion macros and macros you define for#ifdefguards. Anyway,man gccsays "[-Dmacro[=defn]...] [-Umacro], so I think "macro" is correct.CC: @elprans
https://bugs.python.org/issue36722