gh-130052: Fix some exceptions on error paths in _testexternalinspection#130053
Conversation
|
cpython/Modules/_testexternalinspection.c Line 917 in 67072cc Refcnt doesn't used - maybe we may remove this reading? cpython/Modules/_testexternalinspection.c Line 1529 in 67072cc This is a typo - should I fix them? get_stack_trace should be get_async_stack_trace
|
Sorry, something went wrong.
|
@pablogsal Please take a look. I saw your fixed some calls (#129557), I added a few more exceptions. I also added a check of the result before it is used. |
Sorry, something went wrong.
|
@sergey-miryanov: Why did you mark this PR as a draft? Do you expect to add more changes? Or is there something else? |
Sorry, something went wrong.
Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner
left a comment
There was a problem hiding this comment.
LGTM.
Sorry, something went wrong.
|
Thanks @sergey-miryanov for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry, something went wrong.
|
Sorry, @sergey-miryanov and @vstinner, I could not cleanly backport this to |
Sorry, something went wrong.
|
@vstinner It looks like a lot of changes were made on 3.14 branch and not on 3.13. Should we backport this PR then? |
Sorry, something went wrong.
|
The automated backport failed because of merge conflicts. @sergey-miryanov: Can you please try to backport this change manually to 3.13? |
Sorry, something went wrong.
|
@vstinner I tried yesterday yet. There are commits that not backported: Should I backport them all? |
Sorry, something went wrong.
|
@pablogsal: |
Sorry, something went wrong.
3.13 has half the test cases because there is no async-related introspection and most of the bugs we have been fixing are in the new code. I will try to go over the PRs and see if anything applies to the other code that we had |
Sorry, something went wrong.
|
I'm afraid it is on @pablogsal side now. I'm not against of backporting those commits and if we decide to do this I'm ready to work on backporting. |
Sorry, something went wrong.
|
If it was decided to not backport this, please remove the "needs backport to 3.13" label. |
Sorry, something went wrong.
|
It is on @pablogsal side to take decision of backporting this. I will remove "need backport@ label for now. |
Sorry, something went wrong.
Some error paths don't set Exceptions.
This PR fixes them.