◐ Shell
reader mode source ↗
Skip to content

GH-125722: Increase minimum supported Sphinx to 8.2.0#130444

Merged
AA-Turner merged 1 commit into
python:mainfrom
AA-Turner:docs/min-sphinx-8-2-0
Mar 5, 2025
Merged

GH-125722: Increase minimum supported Sphinx to 8.2.0#130444
AA-Turner merged 1 commit into
python:mainfrom
AA-Turner:docs/min-sphinx-8-2-0

Conversation

@AA-Turner

@AA-Turner AA-Turner commented Feb 22, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

Required for #130376, though I don't know how long is prudent to wait following release to increase the minimum requirement.

A

📚 Documentation preview 📚: https://cpython-previews--130444.org.readthedocs.build/

@AA-Turner AA-Turner added docs needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Feb 22, 2025
@AA-Turner AA-Turner requested a review from hugovk as a code owner February 22, 2025 02:25
@bedevere-app bedevere-app Bot mentioned this pull request Feb 22, 2025
Closed
@vstinner

vstinner commented Feb 24, 2025

Copy link
Copy Markdown
Member

cc @befeleme FYI

@befeleme

befeleme commented Feb 25, 2025

Copy link
Copy Markdown
Contributor

Is this change intended only for main/3.14?
In Fedora, we're currently at Sphinx 8.1.3. I could test the 8.2.1 and bring back info whether we're ready for this coming in the next alpha (I see there are two breaking changes comparing to 8.1.x). In general, we tend to wait ~month with Sphinx releases, because of the rest of the docs ecosystem which moves significantly slower.

@AA-Turner

AA-Turner commented Feb 27, 2025

Copy link
Copy Markdown
Member Author

We'll backport it to 3.13 and 3.12 when merged. See the linked issue (#125722) for context and background of why we've changed this policy. Specifically, I took Miro Hrončok's comment in #125722 (comment) as feedback from Fedora.

A

@befeleme

befeleme commented Feb 27, 2025

Copy link
Copy Markdown
Contributor

I read the linked discussion and see the reasoning. Given the question is when rather than whether, for the developmental version of Fedora we may be able to build the docs coming in the next Pythons releases.

@AA-Turner AA-Turner merged commit e53d105 into python:main Mar 5, 2025
@miss-islington-app

miss-islington-app Bot commented Mar 5, 2025

Copy link
Copy Markdown

Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@AA-Turner AA-Turner deleted the docs/min-sphinx-8-2-0 branch March 5, 2025 00:31
@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs Mar 5, 2025
@bedevere-app

bedevere-app Bot commented Mar 5, 2025

Copy link
Copy Markdown

GH-130858 is a backport of this pull request to the 3.13 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 5, 2025
@AA-Turner @miss-islington
pythonGH-125722: Increase minimum supported Sphinx to 8.2.0 (pythonGH… …
f724dec 
…-130444)

(cherry picked from commit e53d105)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@bedevere-app

bedevere-app Bot commented Mar 5, 2025

Copy link
Copy Markdown

GH-130859 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Mar 5, 2025
AA-Turner added a commit that referenced this pull request Mar 5, 2025
@miss-islington @AA-Turner
[3.13] GH-125722: Increase minimum supported Sphinx to 8.2.0 (GH-130444… …
80cce59 
…) (#130858)

GH-125722: Increase minimum supported Sphinx to 8.2.0 (GH-130444)
(cherry picked from commit e53d105)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
AA-Turner added a commit that referenced this pull request Mar 5, 2025
@miss-islington @AA-Turner
[3.12] GH-125722: Increase minimum supported Sphinx to 8.2.0 (GH-130444… …
919300e 
…) (#130859)

GH-125722: Increase minimum supported Sphinx to 8.2.0 (GH-130444)
(cherry picked from commit e53d105)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou left review comments

@hugovk hugovk hugovk approved these changes

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti

Assignees

No one assigned

Labels

docs Documentation in the Doc dir

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AA-Turner @vstinner @befeleme @encukou @hugovk