{{ message }}
GH-130213: clang-cl: blake2module.c needs to "see" the AVX intrinsics during compiling#130447
Closed
chris-eibl wants to merge 1 commit into
Closed
GH-130213: clang-cl: blake2module.c needs to "see" the AVX intrinsics during compiling#130447chris-eibl wants to merge 1 commit into
chris-eibl wants to merge 1 commit into
Conversation
Member
Sorry, something went wrong.
chris-eibl
commented
Feb 22, 2025
gpshead
approved these changes
Feb 22, 2025
gpshead
left a comment
gpshead
left a comment
Member
There was a problem hiding this comment.
My gut feeling is that this PR is correct. It's unfortunate to do a version check, because clang has supported all of this for ages but it does look like just an oddity per the GH issue of older versions just not exposing the definitions without the compiler flag (oops!) so the version check makes sense and will work.
Sorry, something went wrong.
Member
Author
|
Converted to draft because not needed in case #130483 works out |
Sorry, something went wrong.
zooba
reviewed
Feb 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
PR created based on @zooba's suggestion #129907 (comment) to fix compiling the
blake2module.con Windows with older versions of clang-cl.I think this is a skip-news because clang-cl is quite niche?