◐ Shell
reader mode source ↗
Skip to content

gh-121970: Replace .. coroutine{method,function} with :async:#130448

Merged
AA-Turner merged 3 commits into
python:mainfrom
sobolevn:issue-121970
Feb 22, 2025
Merged

gh-121970: Replace .. coroutine{method,function} with :async:#130448
AA-Turner merged 3 commits into
python:mainfrom
sobolevn:issue-121970

Conversation

@sobolevn

@sobolevn sobolevn commented Feb 22, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

I decided to keep awaitablefunction / awaitablemethod for now, because it is not quite the same as :async:

📚 Documentation preview 📚: https://cpython-previews--130448.org.readthedocs.build/

@bedevere-app bedevere-app Bot mentioned this pull request Feb 22, 2025
Open
@hugovk hugovk added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Feb 22, 2025
@AA-Turner

AA-Turner commented Feb 22, 2025

Copy link
Copy Markdown
Member

I've updated this branch with the changes I had staged locally from my original investigation.

@AA-Turner AA-Turner enabled auto-merge (squash) February 22, 2025 17:51
@AA-Turner AA-Turner merged commit 5ec4bf8 into python:main Feb 22, 2025
@miss-islington-app

miss-islington-app Bot commented Feb 22, 2025

Copy link
Copy Markdown

Thanks @sobolevn for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 22, 2025
@sobolevn @AA-Turner @miss-islington
pythongh-121970: Replace .. coroutine{method,function} with `:async… …
7870255 
…:` (pythonGH-130448)

(cherry picked from commit 5ec4bf8)

Co-authored-by: sobolevn <mail@sobolevn.me>
Co-authored-by: Adam Turner <9087854+aa-turner@users.noreply.github.com>
@miss-islington-app

miss-islington-app Bot commented Feb 22, 2025

Copy link
Copy Markdown

Sorry, @sobolevn and @AA-Turner, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 5ec4bf86b7f4455432aebace996ef390ae3e9302 3.12

@bedevere-app

bedevere-app Bot commented Feb 22, 2025

Copy link
Copy Markdown

GH-130465 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Feb 22, 2025
AA-Turner added a commit to AA-Turner/cpython that referenced this pull request Feb 22, 2025
@sobolevn @AA-Turner
[3.12] pythongh-121970: Replace .. coroutine{method,function} with … …
36ecbfb 
…`:async:` (pythonGH-130448)

(cherry picked from commit 5ec4bf8)

Co-authored-by: sobolevn <mail@sobolevn.me>
Co-authored-by: Adam Turner <9087854+aa-turner@users.noreply.github.com>
@bedevere-app

bedevere-app Bot commented Feb 22, 2025

Copy link
Copy Markdown

GH-130467 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Feb 22, 2025
AA-Turner added a commit that referenced this pull request Feb 22, 2025
@miss-islington @sobolevn @AA-Turner
[3.13] gh-121970: Replace .. coroutine{method,function} with `:asyn… …
c68a872 
…c:` (GH-130448) (#130465)

(cherry picked from commit 5ec4bf8)

Co-authored-by: sobolevn <mail@sobolevn.me>
Co-authored-by: Adam Turner <9087854+aa-turner@users.noreply.github.com>
AA-Turner added a commit that referenced this pull request Feb 22, 2025
@AA-Turner @sobolevn
[3.12] gh-121970: Replace .. coroutine{method,function} with `:asyn… …
9bd92fa 
…c:` (GH-130448) (#130467)

(cherry picked from commit 5ec4bf8)

Co-authored-by: sobolevn <mail@sobolevn.me>
Mr-Sunglasses pushed a commit to Mr-Sunglasses/cpython that referenced this pull request Feb 24, 2025
@sobolevn @Mr-Sunglasses
pythongh-121970: Replace .. coroutine{method,function} with `:async… …
48cb5b5 
…:` (python#130448)

Co-authored-by: Adam Turner <9087854+aa-turner@users.noreply.github.com>

pythongh-130461: Fix locations of `.. index::` directives usage in `Doc/library/uuid.rst`

pythongh-130461: Fix locations of `.. index::` in `getnode()`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 left review comments

@asvetlov asvetlov

@AA-Turner AA-Turner AA-Turner approved these changes

@willingc willingc Awaiting requested review from willingc willingc is a code owner

@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

Assignees

@AA-Turner AA-Turner

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sobolevn @AA-Turner @asvetlov @kumaraditya303 @hugovk