◐ Shell
reader mode source ↗
Skip to content

bpo-13349: Improve the error message for tuple.index#1309

Closed
Zaharid wants to merge 1 commit into
python:masterfrom
Zaharid:fixtupleindex
Closed

bpo-13349: Improve the error message for tuple.index#1309
Zaharid wants to merge 1 commit into
python:masterfrom
Zaharid:fixtupleindex

Conversation

@Zaharid

@Zaharid Zaharid commented Apr 26, 2017 •
edited
Loading

Copy link
Copy Markdown

When the required value is not found, use the same template as
list.index and display the missing value instead of 'x'. The original issue with the discussion is: https://bugs.python.org/issue13349

@Zaharid
Improve the error message for tuple.index …
b70cc0f 
When the required value is not found, use the same template as
list.index and display the missing value instead of 'x'.
@the-knights-who-say-ni

the-knights-who-say-ni commented Apr 26, 2017

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@mention-bot

mention-bot commented Apr 26, 2017

Copy link
Copy Markdown

@Zaharid, thanks for your PR! By analyzing the history of the files in this pull request, we identified @serhiy-storchaka, @rhettinger and @tiran to be potential reviewers.

@louisom louisom mentioned this pull request Apr 27, 2017
Closed
@louisom

louisom commented Apr 27, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

@Zaharid You will need to put the bpo issue number at the front of the title: bpo-13349: Improve..., also, you will need to signed the CLA first.

@Zaharid Zaharid changed the title Improve the error message for tuple.index Apr 27, 2017
@DimitrisJim

DimitrisJim commented Apr 27, 2017

Copy link
Copy Markdown
Contributor

Hi, @Zaharid and thanks for the patch. I had already created a PR for this issue here #876 already, though :-).

@berkerpeksag

berkerpeksag commented Apr 27, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

Closing this as a duplicate of #876.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Zaharid @the-knights-who-say-ni @mention-bot @louisom @DimitrisJim @berkerpeksag