◐ Shell
reader mode source ↗
Skip to content

gh-111178: remove redundant casts for functions with correct signatures#131673

Merged
picnixz merged 24 commits into
python:mainfrom
picnixz:fix/ubsan/casts-111178
Apr 1, 2025
Merged

gh-111178: remove redundant casts for functions with correct signatures#131673
picnixz merged 24 commits into
python:mainfrom
picnixz:fix/ubsan/casts-111178

Conversation

@picnixz

@picnixz picnixz commented Mar 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

This is a cleanup PR but it's easier to hunt non-covered possible UBSans

@bedevere-app bedevere-app Bot mentioned this pull request Mar 24, 2025
Closed
@picnixz

picnixz commented Mar 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

Very interesting. I locally had an issue where my make command hangs (which is the case here) but I still don't know why this happens.

@picnixz

picnixz commented Mar 24, 2025

Copy link
Copy Markdown
Member Author

I think it know what happened! I incorrectly merged main into this branch c:

@picnixz picnixz marked this pull request as ready for review March 30, 2025 09:07
4 hidden items Load more…
@picnixz @vstinner
Update Modules/faulthandler.c …
4bf2a1e 
Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner
vstinner approved these changes Apr 1, 2025
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM

@picnixz picnixz merged commit edbf7fb into python:main Apr 1, 2025
@picnixz picnixz deleted the fix/ubsan/casts-111178 branch April 1, 2025 15:18
@bedevere-bot

bedevere-bot commented Apr 1, 2025

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 FreeBSD Refleaks 3.x (tier-3) has failed when building commit edbf7fb.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1613/builds/1061) and take a look at the build logs.
  4. Check if the failure is related to this commit (edbf7fb) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1613/builds/1061

Failed tests:

  • test.test_concurrent_futures.test_interpreter_pool

Failed subtests:

  • test_map_buffersize - test.test_concurrent_futures.test_interpreter_pool.InterpreterPoolExecutorTest.test_map_buffersize

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/test/test_concurrent_futures/executor.py", line 100, in test_map_buffersize
    res = self.executor.map(str, ints, buffersize=buffersize)
  File "/buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/concurrent/futures/_base.py", line 614, in map
    fs = collections.deque(
        self.submit(fn, *args) for args in islice(zipped_iterables, buffersize)
    )
  File "/buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/concurrent/futures/_base.py", line 615, in <genexpr>
    self.submit(fn, *args) for args in islice(zipped_iterables, buffersize)
    ~~~~~~~~~~~^^^^^^^^^^^
  File "/buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/concurrent/futures/thread.py", line 202, in submit
    raise self.BROKEN(self._broken)
concurrent.futures.interpreter.BrokenInterpreterPool: A thread initializer failed, the thread pool is not usable anymore


Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/concurrent/futures/thread.py", line 99, in _worker
    ctx.initialize()
    ~~~~~~~~~~~~~~^^
  File "/buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/concurrent/futures/interpreter.py", line 132, in initialize
    self.interpid = _interpreters.create(reqrefs=True)
                    ~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^
interpreters.InterpreterError: interpreter creation failed


Traceback (most recent call last):
  File "<frozen getpath>", line 358, in <module>
ValueError: embedded null byte
Exception in initializer:
RuntimeError: error evaluating path


Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/test/support/__init__.py", line 814, in gc_collect
    gc.collect()
ResourceWarning: unclosed <socket.socket fd=8, family=2, type=1, proto=6, laddr=('127.0.0.1', 40376), raddr=('127.0.0.1', 40377)>
Task was destroyed but it is pending!
task: <Task pending name='Task-1035' coro=<BaseSelectorEventLoop._accept_connection2() done, defined at /buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/asyncio/selector_events.py:217> wait_for=<Future pending cb=[Task.task_wakeup()]>>
Warning -- Unraisable exception
Exception ignored while calling deallocator <function _SelectorTransport.__del__ at 0x841c2f290>:
Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/asyncio/selector_events.py", line 873, in __del__
    _warn(f"unclosed transport {self!r}", ResourceWarning, source=self)
ResourceWarning: unclosed transport <_SelectorSocketTransport closing fd=8>
k


Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/concurrent/futures/thread.py", line 99, in _worker
    ctx.initialize()
    ~~~~~~~~~~~~~~^^
  File "/buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/concurrent/futures/interpreter.py", line 132, in initialize
    self.interpid = _interpreters.create(reqrefs=True)
                    ~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^
interpreters.InterpreterError: interpreter creation failed
Timeout (0:45:00)!
Thread 0x000000082e37b000 (most recent call first):
  File "/buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/concurrent/futures/thread.py", line 116 in _worker
  File "/buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/threading.py", line 996 in run
  File "/buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/threading.py", line 1054 in _bootstrap_inner
  File "/buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/threading.py", line 1016 in _bootstrap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@picnixz @bedevere-bot @vstinner