◐ Shell
reader mode source ↗
Skip to content

gh-128813: hide mixed-mode functions for complex arithmetic from C-API#131703

Merged
vstinner merged 2 commits into
python:mainfrom
skirpichev:remove-mixed-api/128813
Apr 22, 2025
Merged

gh-128813: hide mixed-mode functions for complex arithmetic from C-API#131703
vstinner merged 2 commits into
python:mainfrom
skirpichev:remove-mixed-api/128813

Conversation

@skirpichev

@skirpichev skirpichev commented Mar 25, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

@skirpichev skirpichev requested a review from vstinner March 25, 2025 03:43
@bedevere-app bedevere-app Bot mentioned this pull request Mar 25, 2025
Closed
@skirpichev

skirpichev commented Mar 25, 2025

Copy link
Copy Markdown
Member Author

CC @vstinner

@skirpichev skirpichev requested review from a team and erlend-aasland as code owners March 25, 2025 08:40
vstinner
vstinner approved these changes Mar 25, 2025
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM

@skirpichev

skirpichev commented Apr 15, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

CC @serhiy-storchaka

I doubt C-API WG issue will be solved til 3.14 beta1. So, lets remove added functions from the public API.

@skirpichev

skirpichev commented Apr 22, 2025

Copy link
Copy Markdown
Member Author

CC @erlend-aasland

@vstinner

vstinner commented Apr 22, 2025

Copy link
Copy Markdown
Member

Related discussion: capi-workgroup/decisions#56

@skirpichev

skirpichev commented Apr 22, 2025

Copy link
Copy Markdown
Member Author

I just worry, that it will be not finished til 3.14 beta. Or it's ok to revert this stuff after that?

@vstinner vstinner merged commit 79f7c67 into python:main Apr 22, 2025
@vstinner

vstinner commented Apr 22, 2025

Copy link
Copy Markdown
Member

Ok, let's remove them for now. We can revisit this API later if we decide to expose it.

@skirpichev skirpichev deleted the remove-mixed-api/128813 branch April 22, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

Assignees

No one assigned

Labels

skip news

Projects

Release and Deferred blockers 🚫
Status: Done +1 more

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@skirpichev @vstinner