@freakboy3742 can you advise if this is the best way to handle this? The error was:

HEAD is now at 943cc1431eb gh-131591: Implement PEP 768 (#131937)
Switched to and reset branch 'main'

configure: WARNING: no system libmpdecimal found; falling back to bundled libmpdecimal (deprecated and scheduled for removal in Python 3.15)
configure: WARNING: pkg-config is missing. Some dependencies may not be detected correctly.

configure: WARNING: no system libmpdecimal found; falling back to bundled libmpdecimal (deprecated and scheduled for removal in Python 3.15)
configure: WARNING: pkg-config is missing. Some dependencies may not be detected correctly.

../../Python/remote_debugging.c:30:14: fatal error: 'libproc.h' file not found
   30 | #    include <libproc.h>
      |              ^~~~~~~~~~~
1 error generated.
make: *** [Python/remote_debugging.o] Error 1

find: build: No such file or directory
find: build: No such file or directory
find: build: No such file or directory
find: build: No such file or directory
make: [clean-retain-profile] Error 1 (ignored)

!buildbot simulator

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 3ec2116 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F132050%2Fmerge

The command will test the builders whose names match following regular expression: simulator

The builders matched are:

• iOS ARM64 Simulator PR

!buildbot simulator

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 1e29ec6 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F132050%2Fmerge

The command will test the builders whose names match following regular expression: simulator

The builders matched are:

• iOS ARM64 Simulator PR

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@freakboy3742 If you prefer we can use the if !defined(TARGET_OS_OSX) && !(defined(TARGET_OS_IPHONE) && TARGET_OS_IPHONE) version. Would you prefer that instead of the current approach? I selected this based on your code in _testexternalinspection.c

I selected this based on your code in _testexternalinspection.c

... huh. Well now I've been hoist with my own petard.

I've gone on a bit of a code dive to see how big a change reverting #define TARGET_OS_OSX 1 would be, and the more I look, the more the "redefining" approach seems the pragmatic choice. There's lots of "bare" uses of TARGET_OS_OSX that are already impacted by the existing definitions, and none of those are made easier to read by requiring an explicit defined(TARGET_OS_OSX) as a prefix. And, if someone forgets that the defined(TARGET_OS_OSX) is required, that's an automatic breakage for old macOS versions - so having the redefine in place is a good safety catch.

So - lets go with the redefine-based approach you've got here.

All commit authors signed the Contributor License Agreement.