◐ Shell
reader mode source ↗
Skip to content

bpo-36854: Move GC runtime state from _PyRuntimeState to PyInterpreterState.#13219

Closed
ericsnowcurrently wants to merge 3 commits into
python:masterfrom
ericsnowcurrently:runtime-interp-gc
Closed

bpo-36854: Move GC runtime state from _PyRuntimeState to PyInterpreterState.#13219
ericsnowcurrently wants to merge 3 commits into
python:masterfrom
ericsnowcurrently:runtime-interp-gc

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented May 9, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Note: as part of this PR, I've made sure that Python threads (created by the threading module) are marked as "deleted" earlier in finalization. That marker is how joining threads get unblocked. It was happening in PyThreadState_Delete() but now it will happen in PyThreadState_Clear(). This is necessary to ensure that the callback gets called before much interpreter/runtime finalization happens. (It could impact daemon threads, but we already can't guarantee behavior for those once finalization starts.)

https://bugs.python.org/issue36854

@pablogsal pablogsal requested review from pablogsal and vstinner May 10, 2019 17:33
@ericsnowcurrently ericsnowcurrently mentioned this pull request May 10, 2019
Merged
vstinner
vstinner requested changes May 10, 2019
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

I like what I see: -) But I have some comments on the actual implementation.

@bedevere-bot

bedevere-bot commented May 10, 2019

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@csabella

csabella commented May 31, 2019

Copy link
Copy Markdown
Contributor

@ericsnowcurrently, were you wanting to land this for 3.8?

@brettcannon brettcannon removed their request for review May 31, 2019 19:08
@encukou encukou removed their request for review September 12, 2019 14:04
@vstinner

vstinner commented Nov 20, 2019

Copy link
Copy Markdown
Member

I wrote a different change, PR #17287, that I just merged. So I close this old PR. Thanks anyway Eric for working on this, my work is partially based on yours ;-)

@vstinner vstinner closed this Nov 20, 2019
@ericsnowcurrently

ericsnowcurrently commented Nov 22, 2019

Copy link
Copy Markdown
Member Author

Thanks for doing it!!!

@ericsnowcurrently ericsnowcurrently deleted the runtime-interp-gc branch November 22, 2019 22:17
@vstinner

vstinner commented Nov 22, 2019

Copy link
Copy Markdown
Member

Thanks for doing it!!!

You're welcome.

@vstinner vstinner mentioned this pull request Jan 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner

@ncoghlan ncoghlan

@warsaw warsaw Awaiting requested review from warsaw

@pablogsal pablogsal

Assignees

No one assigned

Labels

awaiting changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ericsnowcurrently @bedevere-bot @csabella @vstinner @the-knights-who-say-ni