{{ message }}
GH-130328: further speedup of pasting in new REPL on Windows by reading in chunks#132889
Closed
chris-eibl wants to merge 14 commits into
Closed
GH-130328: further speedup of pasting in new REPL on Windows by reading in chunks#132889chris-eibl wants to merge 14 commits into
chris-eibl wants to merge 14 commits into
Conversation
Member
Sorry, something went wrong.
chris-eibl
requested review from
ambv,
lysnikolaou and
pablogsal
as code owners
April 24, 2025 20:45
chris-eibl
commented
Apr 24, 2025
chris-eibl
commented
Apr 24, 2025
in class Reader
to use self.paste_mode instead of self.in_bracketed_paste in class Reader
This reverts commit bba26c9.
to revert "use self.paste_mode instead of self.in_bracketed_paste"
# Conflicts: # Lib/_pyrepl/windows_console.py
it isn't used in the whole code, and some code paths in WindowsConsole set it to str instead of bytes
…into read_chunked
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 participant
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
This is on top of #132884. So reviews should be done beginning with commit a64f4c4.