{{ message }}
gh-91048: Chain some exceptions in _testexternalinspection.c#132970
Merged
pablogsal merged 8 commits intoMay 2, 2025
Merged
Conversation
picnixz
reviewed
Apr 25, 2025
- I believe it is not worth to add conditional compilation of such small function like chain_exceptions
pablogsal
approved these changes
May 2, 2025
pablogsal
left a comment
pablogsal
left a comment
Member
There was a problem hiding this comment.
LGTM
This is a great improvement. Thanks a lot!
Sorry, something went wrong.
pablogsal
approved these changes
May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
edited
LoadingUh oh!
There was an error while loading. Please reload this page.
Copy link Copy MarkdownSorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.