◐ Shell
reader mode source ↗
Skip to content

GH-133231: Add JIT utilities in sys._jit#133233

Merged
brandtbucher merged 17 commits into
python:mainfrom
brandtbucher:sys-jit
May 5, 2025
Merged

GH-133231: Add JIT utilities in sys._jit#133233
brandtbucher merged 17 commits into
python:mainfrom
brandtbucher:sys-jit

Conversation

@brandtbucher

@brandtbucher brandtbucher commented May 1, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

@brandtbucher brandtbucher added type-feature A feature request or enhancement interpreter-core (Objects, Python, Grammar, and Parser dirs) topic-JIT labels May 1, 2025
@brandtbucher brandtbucher self-assigned this May 1, 2025
@bedevere-app bedevere-app Bot mentioned this pull request May 1, 2025
Closed
AA-Turner
AA-Turner reviewed May 1, 2025
View reviewed changes

@AA-Turner AA-Turner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

quick doc-only review:

@brandtbucher

brandtbucher commented May 1, 2025

Copy link
Copy Markdown
Member Author

I just realized that my approach for sys._jit.is_active() will need reworking, since the tail-calling interpreter doesn't have entry_frame handy.

@brandtbucher

brandtbucher commented May 1, 2025

Copy link
Copy Markdown
Member Author

Okay, reworked to support tail-calling.

@brandtbucher

brandtbucher commented May 2, 2025

Copy link
Copy Markdown
Member Author

@markshannon, let me know what you think. The bots won't let us merge features without approving review, but I'd like to get something like this in before the freeze.

markshannon
markshannon reviewed May 5, 2025
View reviewed changes

@markshannon markshannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Looks good.
One small suggestion

Hide details View details @brandtbucher brandtbucher merged commit b1aa515 into python:main May 5, 2025
48 checks passed
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@brandtbucher @Pranjal095
pythonGH-133231: Add JIT utilities in sys._jit (pythonGH-133233)
aeb8e07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AA-Turner AA-Turner

@markshannon markshannon markshannon approved these changes

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Assignees

@brandtbucher brandtbucher

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) topic-JIT type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brandtbucher @AA-Turner @markshannon