◐ Shell
reader mode source ↗
Skip to content

[3.7] Revert "bpo-36801: Fix waiting in StreamWriter.drain for closing SSL transport (GH-13098)"#13328

Merged
vstinner merged 1 commit into
python:3.7from
vstinner:revert_asyncio_ssl37
May 14, 2019
Merged

[3.7] Revert "bpo-36801: Fix waiting in StreamWriter.drain for closing SSL transport (GH-13098)"#13328
vstinner merged 1 commit into
python:3.7from
vstinner:revert_asyncio_ssl37

Conversation

@vstinner

@vstinner vstinner commented May 14, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@vstinner vstinner changed the title Revert "bpo-36801: Fix waiting in StreamWriter.drain for closing SSL transport (GH-13098)" May 14, 2019
@vstinner

vstinner commented May 14, 2019

Copy link
Copy Markdown
Member Author

The revert is motivated by https://bugs.python.org/issue36870 : test_asyncio fails randomly which causes a lot of pain in the Python CI and the Python workflow. See:
https://bugs.python.org/issue36870#msg342509

@asvetlov

asvetlov commented May 14, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

I guess the reversion PR should be backported to 3.7 as well

UPD.
Sorry, I mean master.

This PR is a reversion for #13176 on 3.7
#13098 should be reverted on the master too

@vstinner

vstinner commented May 14, 2019

Copy link
Copy Markdown
Member Author

I guess the reversion PR should be backported to 3.7 as well

This revert is for Python 3.7.

@asvetlov

asvetlov commented May 14, 2019

Copy link
Copy Markdown
Contributor

Sorry, I mean the same code should be reverted on the master too

@vstinner

vstinner commented May 14, 2019

Copy link
Copy Markdown
Member Author

Without this change, I easily reproduce the failure on Windows:

vstinner@WIN C:\vstinner\python\3.7>python -m test test_asyncio -m test_drain_raises -v
(...)
test_drain_raises (test.test_asyncio.test_streams.StreamTests) ... Warning -- threading_cleanup() failed to cleanup 0 threads (count: 0, dangling: 2)     
Dangling thread: <Thread(Thread-1, stopped daemon 1568)>
Dangling thread: <_MainThread(MainThread, started 1244)>
ERROR

======================================================================
ERROR: test_drain_raises (test.test_asyncio.test_streams.StreamTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\vstinner\python\3.7\lib\test\test_asyncio\test_streams.py", line 820, in test_drain_raises
    self.loop.run_until_complete(client(*addr))
  File "C:\vstinner\python\3.7\lib\asyncio\base_events.py", line 584, in run_until_complete
    return future.result()
  File "C:\vstinner\python\3.7\lib\test\test_asyncio\test_streams.py", line 810, in client
    await writer.drain()
  File "C:\vstinner\python\3.7\lib\asyncio\streams.py", line 351, in drain
    await fut
  File "C:\vstinner\python\3.7\lib\asyncio\selector_events.py", line 860, in write
    n = self._sock.send(data)
ConnectionAbortedError: [WinError 10053] An established connection was aborted by the software in your host machine
(...)

With this change, the test pass as expected:

vstinner@WIN C:\vstinner\python\3.7>python -m test test_asyncio -m test_drain_raises -v
(...)
test_drain_raises (test.test_asyncio.test_streams.StreamTests) ... ok
(...)
Tests result: SUCCESS

@vstinner vstinner merged commit c647ad9 into python:3.7 May 14, 2019
@vstinner vstinner deleted the revert_asyncio_ssl37 branch May 14, 2019 20:30
@asvetlov

asvetlov commented May 14, 2019

Copy link
Copy Markdown
Contributor

Cool!
Sorry for making troubles :(

@vstinner

vstinner commented May 14, 2019

Copy link
Copy Markdown
Member Author

Sorry, I mean the same code should be reverted on the master too

Well, I don't know yet if PR #13313 fixed https://bugs.python.org/issue36870 on master. Anyway, I created PR #13329 for master.

@vstinner vstinner mentioned this pull request May 14, 2019
Closed
@asvetlov asvetlov mentioned this pull request Apr 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asvetlov asvetlov asvetlov approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vstinner @asvetlov @the-knights-who-say-ni @bedevere-bot