◐ Shell
reader mode source ↗
Skip to content

gh-133367: Add missing options to ast CLI#133369

Merged
sobolevn merged 13 commits into
python:mainfrom
donbarbos:issue-133367
May 5, 2025
Merged

gh-133367: Add missing options to ast CLI#133369
sobolevn merged 13 commits into
python:mainfrom
donbarbos:issue-133367

Conversation

@donbarbos

@donbarbos donbarbos commented May 4, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

I wasn't sure about adding whatsnew entry but I added it so we can remote it

*Headings were corrected according to the devguide

cc @sobolevn

📚 Documentation preview 📚: https://cpython-previews--133369.org.readthedocs.build/

@bedevere-app bedevere-app Bot mentioned this pull request May 4, 2025
Closed
@skirpichev skirpichev requested a review from sobolevn May 4, 2025 10:37
sobolevn
sobolevn reviewed May 4, 2025
View reviewed changes

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Please, don't forget to add tests in your other PR

@skirpichev

skirpichev commented May 4, 2025

Copy link
Copy Markdown
Member

Please, don't forget to add tests in your other PR

Probably, that one (i.e. #133329) should be merged first.

StanFromIreland
StanFromIreland reviewed May 4, 2025
View reviewed changes

@StanFromIreland StanFromIreland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Some docs notes

donbarbos and others added 2 commits May 4, 2025 16:46
@donbarbos @StanFromIreland
Apply suggestions from code review …
c296107 
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@donbarbos
Revert "add gaps"
af4d1c3
sobolevn
sobolevn reviewed May 4, 2025
View reviewed changes

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Now please rebase this PR and add tests :)

donbarbos and others added 2 commits May 5, 2025 02:26
@donbarbos
Merge branch 'main' into issue-133367
1b2e538
@donbarbos @StanFromIreland
Update Misc/NEWS.d/next/Library/2025-05-04-13-40-05.gh-issue-133367.E… …
6aac4bf 
…5nl2u.rst

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@sobolevn sobolevn requested a review from hugovk May 4, 2025 22:47
sobolevn
sobolevn approved these changes May 5, 2025
View reviewed changes

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM

sobolevn
sobolevn approved these changes May 5, 2025
View reviewed changes

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

One more suggestion: let's add defaults to the docs.

sobolevn
sobolevn approved these changes May 5, 2025
View reviewed changes

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thank you! 🎉

@sobolevn sobolevn enabled auto-merge (squash) May 5, 2025 16:55
Hide details View details @sobolevn sobolevn merged commit 2b4e2b7 into python:main May 5, 2025
39 checks passed
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@donbarbos @StanFromIreland
@sobolevn @Pranjal095
pythongh-133367: Add missing options to ast CLI (python#133369) …
f179f09 
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: sobolevn <mail@sobolevn.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevn sobolevn sobolevn approved these changes

@tomasr8 tomasr8 tomasr8 left review comments

@picnixz picnixz

@StanFromIreland StanFromIreland StanFromIreland left review comments

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@hugovk hugovk hugovk approved these changes

@isidentical isidentical Awaiting requested review from isidentical isidentical is a code owner

@Eclips4 Eclips4 Awaiting requested review from Eclips4 Eclips4 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@donbarbos @skirpichev @JelleZijlstra @hugovk @sobolevn @tomasr8 @picnixz @StanFromIreland