◐ Shell
reader mode source ↗
Skip to content

GH-91048: Minor fixes for _remotedebugging & rename to _remote_debugging#133398

Merged
pablogsal merged 6 commits into
python:mainfrom
AA-Turner:remote-debug-misc
May 5, 2025
Merged

GH-91048: Minor fixes for _remotedebugging & rename to _remote_debugging#133398
pablogsal merged 6 commits into
python:mainfrom
AA-Turner:remote-debug-misc

Conversation

@AA-Turner

@AA-Turner AA-Turner commented May 4, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

cc @pablogsal, a few minor things I spotted after the rename in #133284.

Btw, would you support adding an underscore to the module name? I keep reading it as 'remoted ...', and _remote_debugging would better match the C files.

A

@AA-Turner AA-Turner requested review from a team, corona10 and erlend-aasland as code owners May 4, 2025 19:49
@bedevere-app bedevere-app Bot mentioned this pull request May 4, 2025
Closed
@bedevere-app bedevere-app Bot added and removed awaiting core review labels May 4, 2025
@pablogsal

pablogsal commented May 4, 2025

Copy link
Copy Markdown
Member

Thanks a lot for the fix @AA-Turner!

@pablogsal

pablogsal commented May 4, 2025

Copy link
Copy Markdown
Member

Btw, would you support adding an underscore to the module name? I keep reading it as 'remoted ...', and _remote_debugging would better match the C files.

Yep, if you want, go ahead and make the changes

@AA-Turner AA-Turner changed the title GH-91048: Minor fixes after renaming to _remotedebugging May 4, 2025
@AA-Turner AA-Turner added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 4, 2025
@bedevere-bot

bedevere-bot commented May 4, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @AA-Turner for commit 2e6b80e 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133398%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 4, 2025
@pablogsal

pablogsal commented May 4, 2025

Copy link
Copy Markdown
Member

Hummmm, seems that this collided with the other PR, could you rebase? I can land it afterwards.

If you don't have time I can rebase myself if you prefer :)

@AA-Turner
Merge branch 'main' into remote-debug-misc …
d53db6b 
# Conflicts:
#	Lib/test/test_external_inspection.py
@AA-Turner

AA-Turner commented May 4, 2025

Copy link
Copy Markdown
Member Author

Thanks! resolved conflicts

A

Hide details View details @pablogsal pablogsal merged commit 3f80165 into python:main May 5, 2025
41 checks passed
@pablogsal

pablogsal commented May 5, 2025

Copy link
Copy Markdown
Member

Thanks again 🖤

@AA-Turner AA-Turner deleted the remote-debug-misc branch May 5, 2025 00:34
@zanieb zanieb mentioned this pull request May 17, 2025
Merged
zanieb added a commit to astral-sh/python-build-standalone that referenced this pull request Jun 4, 2025
@zanieb @Wingysam @geofft
Update to 3.14.0b1 (#610) …
d2030cb 
- python/cpython#133027
- python/cpython#133366
- python/cpython#133284
- python/cpython#133398
- python/cpython#131298
- python/cpython#132438
- python/cpython#133012

---------

Co-authored-by: Wingy <git@wingysam.xyz>
Co-authored-by: Geoffrey Thomas <geofft@ldpreload.com>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@AA-Turner @Pranjal095
pythonGH-91048: Minor fixes for _remotedebugging & rename to ``_r… …
e2c898b 
…emote_debugging`` (python#133398)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AA-Turner @pablogsal @bedevere-bot