◐ Shell
reader mode source ↗
Skip to content

gh-132983: Remove pyzstd in identifiers#133535

Merged
AA-Turner merged 3 commits into
python:mainfrom
Rogdham:remove-pyzstd-in-identifiers
May 8, 2025
Merged

gh-132983: Remove pyzstd in identifiers#133535
AA-Turner merged 3 commits into
python:mainfrom
Rogdham:remove-pyzstd-in-identifiers

Conversation

@Rogdham

@Rogdham Rogdham commented May 6, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

The _PyZstd_xxx extern functions were leftover artifacts of the move from pyzstd to cpython.

I have renamed them to the _zstd_xxx convention used for private functions.

@python-cla-bot

python-cla-bot Bot commented May 6, 2025 •
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app bedevere-app Bot mentioned this pull request May 6, 2025
Closed
13 tasks
@Rogdham Rogdham marked this pull request as ready for review May 6, 2025 20:04
@Rogdham

Rogdham commented May 6, 2025

Copy link
Copy Markdown
Contributor Author

Thanks @emmatyping for the explanation about the context, pinging you for review as suggested 🤗

@ZeroIntensity ZeroIntensity requested a review from emmatyping May 6, 2025 20:56
emmatyping
emmatyping reviewed May 7, 2025
View reviewed changes

@emmatyping emmatyping left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Looks good! Just want to make sure we make these static since they are local to their translation unit (file).

emmatyping
emmatyping approved these changes May 7, 2025
View reviewed changes

@emmatyping emmatyping left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Test failure looks unrelated. Thanks for the PR!

@bedevere-app bedevere-app Bot added and removed awaiting review labels May 7, 2025
@AA-Turner

AA-Turner commented May 8, 2025

Copy link
Copy Markdown
Member

Note: in general we don't need to update the branch, it wastes CI resources. I tend to do so only sparingly.

Hide details View details @AA-Turner AA-Turner merged commit 2cc6de7 into python:main May 8, 2025
38 checks passed
@AA-Turner AA-Turner added the needs backport to 3.14 bugs and security fixes label May 8, 2025
@miss-islington-app

miss-islington-app Bot commented May 8, 2025

Copy link
Copy Markdown

Thanks @Rogdham for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 8, 2025
@Rogdham @miss-islington
pythongh-132983: Remove pyzstd in identifiers (pythonGH-133535) …
05ebe02 
(cherry picked from commit 2cc6de7)

Co-authored-by: Rogdham <3994389+Rogdham@users.noreply.github.com>
@bedevere-app

bedevere-app Bot commented May 8, 2025

Copy link
Copy Markdown

GH-133629 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label May 8, 2025
@emmatyping

emmatyping commented May 8, 2025

Copy link
Copy Markdown
Member

Note: in general we don't need to update the branch, it wastes CI resources. I tend to do so only sparingly.

I only did so to sort out CI failures which would block merge.

@AA-Turner

AA-Turner commented May 8, 2025

Copy link
Copy Markdown
Member

Sorry! I missed that, thanks.

@Rogdham Rogdham deleted the remove-pyzstd-in-identifiers branch May 8, 2025 05:51
AA-Turner pushed a commit that referenced this pull request May 8, 2025
@miss-islington
[3.14] gh-132983: Remove pyzstd in identifiers (GH-133535) (#133629)
c6a56e3
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@Rogdham @Pranjal095
pythongh-132983: Remove pyzstd in identifiers (python#133535)
973e9f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AA-Turner AA-Turner AA-Turner approved these changes

@emmatyping emmatyping emmatyping approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Rogdham @AA-Turner @emmatyping