◐ Shell
reader mode source ↗
Skip to content

bpo-36763: Add _Py_InitializeMain()#13362

Merged
vstinner merged 1 commit into
python:masterfrom
vstinner:pep587_init_main
May 16, 2019
Merged

bpo-36763: Add _Py_InitializeMain()#13362
vstinner merged 1 commit into
python:masterfrom
vstinner:pep587_init_main

Conversation

@vstinner

@vstinner vstinner commented May 16, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member
  • Add again _PyCoreConfig._init_main
  • _PyCoreConfig: rename _frozen to pathconfig_warnings, its value is
    not the opposite of Py_FrozenFlag.
  • Add an unit test for _init_main=0 and _Py_InitializeMain()

https://bugs.python.org/issue36763

@vstinner
bpo-36763: Add _Py_InitializeMain() …
e95d4f6 
* Add again _PyCoreConfig._init_main
* _PyCoreConfig: rename _frozen to pathconfig_warnings, its value is
  not the opposite of Py_FrozenFlag.
* Add an unit test for _init_main=0 and _Py_InitializeMain()
@vstinner

vstinner commented May 16, 2019

Copy link
Copy Markdown
Member Author

@zooba @Yhg1s @ncoghlan: Ok, here you have, a simple change to allow to execute Python code between _Py_InitializeFromConfig() and _Py_InitializeMain(). Using a small change in run_eval_code_obj() (set builtins in globals), it becomes even possible to use import before _Py_InitializeMain() ;-)

See included unit test:

static int test_init_main(void)
{
    _PyCoreConfig config = _PyCoreConfig_INIT;
    configure_init_main(&config);
    config._init_main = 0;

    _PyInitError err = _Py_InitializeFromConfig(&config);
    if (_Py_INIT_FAILED(err)) {
        _Py_ExitInitError(err);
    }

    /* sys.stdout don't exist yet: it is created by _Py_InitializeMain() */
    int res = PyRun_SimpleString(
        "import sys; "
        "print('Run Python code before _Py_InitializeMain', "
               "file=sys.stderr)");
    if (res < 0) {
        exit(1);
    }

    err = _Py_InitializeMain();
    if (_Py_INIT_FAILED(err)) {
        _Py_ExitInitError(err);
    }

    return _Py_RunMain();
}

Maybe _Py_InitializeMain() can be added to PEP 587 as an experimental feature until we decide how to implement PEP 432.

@vstinner

vstinner commented May 16, 2019

Copy link
Copy Markdown
Member Author

I merge this PR right now, because it fix a _Py_InitializeFromConfig() bug. _Py_InitializeMainInterpreter() must be called even if pathconfig_warnings is 0. pathconfig_warnings and _init_main must not be related. I was wrong when I removed _PyCoreConfig._init_main.

@vstinner vstinner merged commit 9ef5dca into python:master May 16, 2019
@vstinner vstinner deleted the pep587_init_main branch May 16, 2019 15:38
@YannickJadoul YannickJadoul mentioned this pull request Aug 4, 2020
Closed
@YannickJadoul YannickJadoul mentioned this pull request Oct 23, 2020
Merged
@henryiii henryiii mentioned this pull request Oct 26, 2021
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon Awaiting requested review from brettcannon

@encukou encukou Awaiting requested review from encukou

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently

@ncoghlan ncoghlan Awaiting requested review from ncoghlan

@warsaw warsaw Awaiting requested review from warsaw

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner @the-knights-who-say-ni @bedevere-bot