◐ Shell
reader mode source ↗
Skip to content

gh-133644: remove deprecated PyImport_ImportModuleNoBlock#133655

Merged
picnixz merged 6 commits into
python:mainfrom
picnixz:cleanup/315/deprecated-import-133644
May 8, 2025
Merged

gh-133644: remove deprecated PyImport_ImportModuleNoBlock#133655
picnixz merged 6 commits into
python:mainfrom
picnixz:cleanup/315/deprecated-import-133644

Conversation

@picnixz

@picnixz picnixz commented May 8, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-app bedevere-app Bot mentioned this pull request May 8, 2025
Open
9 tasks
@bedevere-app bedevere-app Bot added the label May 8, 2025
@vstinner

vstinner commented May 8, 2025

Copy link
Copy Markdown
Member

A search on PyPI top 8,000 projects found usage in 2 projects:

  • dukpy (0.5.0)
  • google-cloud-profiler (4.1.0)
dukpy-0.5.0.tar.gz: dukpy-0.5.0/src/capsulethunk.h: object = PyImport_ImportModuleNoBlock(trace);

google-cloud-profiler-4.1.0.tar.gz: google-cloud-profiler-4.1.0/googlecloudprofiler/src/log.cc: logging = PyImport_ImportModuleNoBlock("logging");

vstinner
vstinner approved these changes May 8, 2025
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM

@picnixz picnixz enabled auto-merge (squash) May 8, 2025 12:57
Hide details View details @picnixz picnixz merged commit a2c4467 into python:main May 8, 2025
43 checks passed
@picnixz picnixz deleted the cleanup/315/deprecated-import-133644 branch May 8, 2025 13:13
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@picnixz @Pranjal095
pythongh-133644: remove deprecated PyImport_ImportModuleNoBlock (py… …
b218a11 
…thon#133655)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@picnixz @taegyunkim
pythongh-133644: remove deprecated PyImport_ImportModuleNoBlock (py… …
25fae29 
…thon#133655)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner

@encukou encukou Awaiting requested review from encukou

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@picnixz @vstinner