{{ message }}
GH-132983: Remove subclassing support from zstd types#133694
Merged
AA-Turner merged 1 commit intoMay 8, 2025
Merged
Conversation
13 tasks
Rogdham
approved these changes
May 8, 2025
Rogdham
left a comment
Contributor
There was a problem hiding this comment.
LGTM, I also confirmed it works as intended.
I just noticed the case difference between zstdcompressor_type_spec and ZstdDecompressor_type_spec (and same for …_slots), but maybe it's for an other PR?
Sorry, something went wrong.
Hide details
View details
AA-Turner
merged commit
bd7c585
into
python:main
May 8, 2025
42 checks passed
|
Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 9, 2025
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
…33694) For consistency with ``bz2``, ``lzma``, and ``zlib``.
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
…33694) For consistency with ``bz2``, ``lzma``, and ``zlib``.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
cc @Rogdham