◐ Shell
reader mode source ↗
Skip to content

gh-134939: Add the interpreters Module#133958

Merged
ericsnowcurrently merged 17 commits into
python:mainfrom
ericsnowcurrently:pep-734-accepted
Jun 11, 2025
Merged

gh-134939: Add the interpreters Module#133958
ericsnowcurrently merged 17 commits into
python:mainfrom
ericsnowcurrently:pep-734-accepted

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented May 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

@ericsnowcurrently ericsnowcurrently added the needs backport to 3.14 bugs and security fixes label May 13, 2025
@ericsnowcurrently ericsnowcurrently force-pushed the pep-734-accepted branch 4 times, most recently from 7ddfb50 to 5c8545a Compare May 27, 2025 17:59
@bedevere-bot

bedevere-bot commented May 27, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 5c8545a 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133958%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 27, 2025
@ericsnowcurrently ericsnowcurrently force-pushed the pep-734-accepted branch 2 times, most recently from 1e34abd to c63b6bc Compare May 29, 2025 20:56
@ericsnowcurrently ericsnowcurrently added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 29, 2025
@bedevere-bot

bedevere-bot commented May 29, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit c63b6bc 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133958%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 29, 2025
@ericsnowcurrently

ericsnowcurrently commented May 30, 2025

Copy link
Copy Markdown
Member Author

FTR, I ran this against the buildbots and there were two failures:

Neither looks related, but I'll rerun them just to be sure.

@ericsnowcurrently ericsnowcurrently changed the title Add the interpreters Module May 30, 2025
@bedevere-app bedevere-app Bot mentioned this pull request May 30, 2025
Open
4 tasks
@ericsnowcurrently

ericsnowcurrently commented May 30, 2025

Copy link
Copy Markdown
Member Author

!buildbot aarch64 RHEL8 Refleaks

@bedevere-bot

bedevere-bot commented May 30, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 0a5d0e4 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133958%2Fmerge

The command will test the builders whose names match following regular expression: aarch64 RHEL8 Refleaks

The builders matched are:

  • aarch64 RHEL8 Refleaks PR

@ericsnowcurrently

ericsnowcurrently commented May 30, 2025

Copy link
Copy Markdown
Member Author

!buildbot wasm32-wasi Non-Debug

@bedevere-bot

bedevere-bot commented May 30, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 0a5d0e4 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133958%2Fmerge

The command will test the builders whose names match following regular expression: wasm32-wasi Non-Debug

The builders matched are:

  • wasm32-wasi Non-Debug PR

@ericsnowcurrently ericsnowcurrently marked this pull request as ready for review May 30, 2025 19:30
74 hidden items Load more…
@ericsnowcurrently

ericsnowcurrently commented Jun 6, 2025

Copy link
Copy Markdown
Member Author

!buildbot PPC64LE RHEL8 LTO + PGO

@bedevere-bot

bedevere-bot commented Jun 6, 2025

Copy link
Copy Markdown

The regex 'PPC64LE RHEL8 LTO + PGO' did not match any buildbot builder. Is the requested builder in the list of stable builders?

@ericsnowcurrently

ericsnowcurrently commented Jun 6, 2025

Copy link
Copy Markdown
Member Author

!buildbot PPC64LE RHEL8 LTO + PGO

@bedevere-bot

bedevere-bot commented Jun 6, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit e4cbc66 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133958%2Fmerge

The command will test the builders whose names match following regular expression: PPC64LE RHEL8 LTO \+ PGO

The builders matched are:

  • PPC64LE RHEL8 LTO + PGO PR

@ericsnowcurrently

ericsnowcurrently commented Jun 6, 2025

Copy link
Copy Markdown
Member Author

I'll merge this once I've verified that buildbot passes.

@ericsnowcurrently @hugovk
Apply suggestions from code review. …
c0b637e 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@ericsnowcurrently

ericsnowcurrently commented Jun 11, 2025

Copy link
Copy Markdown
Member Author

I'll merge this in a couple hours unless I hear any objections.

Hide details View details @ericsnowcurrently ericsnowcurrently merged commit 6214373 into python:main Jun 11, 2025
39 checks passed
@miss-islington-app

miss-islington-app Bot commented Jun 11, 2025

Copy link
Copy Markdown

Thanks @ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@ericsnowcurrently ericsnowcurrently deleted the pep-734-accepted branch June 11, 2025 23:35
@miss-islington-app

miss-islington-app Bot commented Jun 11, 2025

Copy link
Copy Markdown

Sorry, @ericsnowcurrently, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 62143736b623fd0bcf998995196a13c4e50bb778 3.14

ericsnowcurrently added a commit to ericsnowcurrently/cpython that referenced this pull request Jun 11, 2025
@ericsnowcurrently
pythongh-134939: Add the concurrent.interpreters Module (pythongh-133958 …
a330995 
)

PEP-734 has been accepted (for 3.14).

(FTR, I'm opposed to putting this under the concurrent package, but
doing so is the SC condition under which the module can land in 3.14.)
@ericsnowcurrently ericsnowcurrently mentioned this pull request Jun 11, 2025
Merged
lkollar pushed a commit to lkollar/cpython that referenced this pull request Jun 19, 2025
@ericsnowcurrently @lkollar
pythongh-134939: Add the concurrent.interpreters Module (pythongh-133958 …
e64fa9f 
)

PEP-734 has been accepted (for 3.14).

(FTR, I'm opposed to putting this under the concurrent package, but
doing so is the SC condition under which the module can land in 3.14.)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@ericsnowcurrently @Pranjal095
pythongh-134939: Add the concurrent.interpreters Module (pythongh-133958 …
0eee7a1 
)

PEP-734 has been accepted (for 3.14).

(FTR, I'm opposed to putting this under the concurrent package, but
doing so is the SC condition under which the module can land in 3.14.)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@ericsnowcurrently @taegyunkim
pythongh-134939: Add the concurrent.interpreters Module (pythongh-133958 …
c09d93c 
)

PEP-734 has been accepted (for 3.14).

(FTR, I'm opposed to putting this under the concurrent package, but
doing so is the SC condition under which the module can land in 3.14.)
@serhiy-storchaka

serhiy-storchaka commented Aug 14, 2025

Copy link
Copy Markdown
Member

Reminder about backporting. @ericsnowcurrently

@AA-Turner

AA-Turner commented Aug 14, 2025

Copy link
Copy Markdown
Member

@serhiy-storchaka the concurrent.interpreters module is present in 3.14! #135414 was the PR to the 3.14 branch.

A

@serhiy-storchaka serhiy-storchaka removed the needs backport to 3.14 bugs and security fixes label Aug 14, 2025
@serhiy-storchaka

serhiy-storchaka commented Aug 14, 2025

Copy link
Copy Markdown
Member

Labels were not updated.

Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@ericsnowcurrently @Agent-Hellboy
pythongh-134939: Add the concurrent.interpreters Module (pythongh-133958 …
2d20220 
)

PEP-734 has been accepted (for 3.14).

(FTR, I'm opposed to putting this under the concurrent package, but
doing so is the SC condition under which the module can land in 3.14.)
@StanFromIreland StanFromIreland mentioned this pull request Aug 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon left review comments

@hugovk hugovk hugovk left review comments

@AA-Turner AA-Turner

@picnixz picnixz picnixz left review comments

@ezio-melotti ezio-melotti ezio-melotti left review comments

@ZeroIntensity ZeroIntensity ZeroIntensity left review comments

@erlend-aasland erlend-aasland erlend-aasland is a code owner

+1 more reviewer

@neonene neonene neonene left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@ericsnowcurrently ericsnowcurrently

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.