◐ Shell
reader mode source ↗
Skip to content

bpo-29573: Fixed unlinking already removed NamedTemporaryFile.#134

Closed
andrewnester wants to merge 1 commit into
python:masterfrom
andrewnester:29573-named-temp-file
Closed

bpo-29573: Fixed unlinking already removed NamedTemporaryFile.#134
andrewnester wants to merge 1 commit into
python:masterfrom
andrewnester:29573-named-temp-file

Conversation

@andrewnester

@andrewnester andrewnester commented Feb 16, 2017 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

briancurtin
briancurtin requested changes Feb 16, 2017
View reviewed changes

@briancurtin briancurtin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Looks fine to me, just needs a small test change.

akruis pushed a commit to akruis/cpython that referenced this pull request Oct 29, 2017
Stackless issue python#134: use Py_TYPE, Py_SIZE and Py_REFCNT …
c7dcca5 
Replace the direct access to PyObject members with the preferred macros.
@brettcannon

brettcannon commented Feb 21, 2018

Copy link
Copy Markdown
Member

To try and help move older pull requests forward, we are going through and backfilling 'awaiting' labels on pull requests that are lacking the label. Based on the current reviews, the best we can tell in an automated fashion is that a core developer requested changes to be made to this pull request.

If/when the requested changes have been made, please leave a comment that says, I have made the requested changes; please review again. That will trigger a bot to flag this pull request as ready for a follow-up review.

@serhiy-storchaka serhiy-storchaka changed the title bpo-29573 - Fixed unlinking already removed NamedTemporaryFile. Mar 26, 2018
akruis pushed a commit to akruis/cpython that referenced this pull request Jun 19, 2018
Stackless issue python#134: use Py_TYPE, Py_SIZE and Py_REFCNT …
b842f61 
Replace the direct access to PyObject members with the preferred macros.
(cherry picked from commit c7dcca5)
@csabella csabella requested a review from briancurtin May 20, 2019 00:56
@flavianh

flavianh commented Jul 21, 2019 •
edited
Loading

Copy link
Copy Markdown

@briancurtin @Yhg1s @brettcannon Is this PR worth being revived? The user's repo does not exist any more. I could take care of it by creating a new PR if you want

@brettcannon

brettcannon commented Jul 26, 2019

Copy link
Copy Markdown
Member

@flavianh up to you if you want to create a new PR to try and solve the problem.

jaraco pushed a commit that referenced this pull request Dec 2, 2022
@pyup-bot @Mariatta
Update cherry_picker from 1.2.0 to 1.2.1 (#134)
bcb7c62
@gvanrossum gvanrossum mentioned this pull request Aug 22, 2023
Closed
This was referenced Feb 11, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yhg1s Yhg1s Yhg1s requested changes

@briancurtin briancurtin Awaiting requested review from briancurtin

Assignees

No one assigned

Labels

awaiting changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@andrewnester @brettcannon @flavianh @briancurtin @Yhg1s @the-knights-who-say-ni