◐ Shell
reader mode source ↗
Skip to content

bpo-36953: Delay removal of ABCs from collections.#13409

Merged
miss-islington merged 4 commits into
python:masterfrom
Carreau:bump-collections-abcs-removal
May 30, 2019
Merged

bpo-36953: Delay removal of ABCs from collections.#13409
miss-islington merged 4 commits into
python:masterfrom
Carreau:bump-collections-abcs-removal

Conversation

@Carreau

@Carreau Carreau commented May 18, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Bump the removal to 3.9, indicate collections.abc available since 3.3,
replace version-changed directive to deprecated-removed.

https://bugs.python.org/issue36953

@Carreau Carreau requested a review from rhettinger as a code owner May 18, 2019 20:02
@Carreau Carreau mentioned this pull request May 18, 2019
Merged
@jdemeyer

jdemeyer commented May 18, 2019

Copy link
Copy Markdown
Contributor

Why do we even have to say in advance when the functionality will be removed? For this deprecation, we already said we would remove it in 3.8 but we don't. So why are we now so certain that it will be removed in 3.9?

@Carreau

Carreau commented May 19, 2019

Copy link
Copy Markdown
Contributor Author

Why do we even have to say in advance when the functionality will be removed? For this deprecation, we already said we would remove it in 3.8 but we don't. So why are we now so certain that it will be removed in 3.9?

The policy is AFAICT removal n+2 after deprecation. We do have to remove at some point no? And adding the version number for removal make it easy to search for all that was marked for removal, as well as give expectation to readers.

In any case here we are just discussing bumping the version number, which should be less controversial than discussing if their should be one.

@ilevkivskyi

ilevkivskyi commented May 19, 2019

Copy link
Copy Markdown
Member

I think this deserves a Misc/NEWS item.

@Carreau

Carreau commented May 20, 2019

Copy link
Copy Markdown
Contributor Author

I think this deserves a Misc/NEWS item.

Why not... done.

@Carreau Carreau changed the title bpo-25988: Delay removal of ABCs from collections. May 20, 2019
Carreau and others added 3 commits May 20, 2019 09:33
@Carreau
bpo-36953: Delay removal of ABCs from collections. …
6daa5fc 
Bump the removal to 3.9, indicate collections.abc available since 3.3,
replace version-changed directive tdeprecated-removed.
@Carreau @tirkarthi
Update Doc/library/collections.rst …
dc5a967 
Co-Authored-By: Xtreak <tir.karthi@gmail.com>
add blurb
c34186d
@Carreau Carreau force-pushed the bump-collections-abcs-removal branch from 0ca83e5 to c34186d Compare May 20, 2019 16:34
@Carreau

Carreau commented May 20, 2019

Copy link
Copy Markdown
Contributor Author

Title and commits were mentioning wrong issues; rebased/edited.

ilevkivskyi
ilevkivskyi approved these changes May 21, 2019
View reviewed changes

@ilevkivskyi ilevkivskyi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thanks for updates, LGTM!

@miss-islington miss-islington merged commit eea47e0 into python:master May 30, 2019
@The-Compiler The-Compiler mentioned this pull request Jul 23, 2019
Merged
@nicktimko nicktimko mentioned this pull request Aug 19, 2019
Merged
rhettinger pushed a commit that referenced this pull request Aug 22, 2019
@The-Compiler @rhettinger
Add missing space to warning message (GH-14915) …
c4106af 
This typo was introduced in GH-13409 when changing the message text.
@miss-islington miss-islington mentioned this pull request Aug 22, 2019
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 22, 2019
@The-Compiler @miss-islington
Add missing space to warning message (pythonGH-14915) …
64fbd5a 
This typo was introduced in pythonGH-13409 when changing the message text.
(cherry picked from commit c4106af)

Co-authored-by: Florian Bruhin <me@the-compiler.org>
rhettinger pushed a commit that referenced this pull request Aug 22, 2019
@miss-islington @The-Compiler @rhettinger
Add missing space to warning message (GH-14915) (GH-15379) …
8ede967 
This typo was introduced in GH-13409 when changing the message text.
(cherry picked from commit c4106af)

Co-authored-by: Florian Bruhin <me@the-compiler.org>
@bmw bmw mentioned this pull request Aug 28, 2019
Closed
@bmw bmw mentioned this pull request Sep 5, 2019
Closed
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@The-Compiler @lisroach
Add missing space to warning message (pythonGH-14915) …
f91e866 
This typo was introduced in pythonGH-13409 when changing the message text.
@miss-islington

miss-islington commented Oct 9, 2019

Copy link
Copy Markdown
Contributor

Thanks @Carreau for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Oct 9, 2019

Copy link
Copy Markdown

GH-16675 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 9, 2019
@miss-islington
bpo-36953: Delay removal of ABCs from collections. (pythonGH-13409) …
8f93b6f 
Bump the removal to 3.9, indicate collections.abc available since 3.3,
replace version-changed directive to deprecated-removed.

https://bugs.python.org/issue36953
(cherry picked from commit eea47e0)

Co-authored-by: Matthias Bussonnier <mbussonnier@ucmerced.edu>
miss-islington added a commit that referenced this pull request Oct 9, 2019
@miss-islington
bpo-36953: Delay removal of ABCs from collections. (GH-13409) …
056fa7f 
Bump the removal to 3.9, indicate collections.abc available since 3.3,
replace version-changed directive to deprecated-removed.

https://bugs.python.org/issue36953
(cherry picked from commit eea47e0)

Co-authored-by: Matthias Bussonnier <mbussonnier@ucmerced.edu>
ned-deily pushed a commit to ned-deily/cpython that referenced this pull request Oct 14, 2019
@miss-islington @ned-deily
bpo-36953: Delay removal of ABCs from collections. (pythonGH-13409) …
42b16b2 
Bump the removal to 3.9, indicate collections.abc available since 3.3,
replace version-changed directive to deprecated-removed.

https://bugs.python.org/issue36953
(cherry picked from commit eea47e0)

Co-authored-by: Matthias Bussonnier <mbussonnier@ucmerced.edu>
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@DinoV
bpo-36953: Delay removal of ABCs from collections. (pythonGH-13409) …
79dd534 
Bump the removal to 3.9, indicate collections.abc available since 3.3,
replace version-changed directive to deprecated-removed.


https://bugs.python.org/issue36953
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@The-Compiler @DinoV
Add missing space to warning message (pythonGH-14915) …
37c7872 
This typo was introduced in pythonGH-13409 when changing the message text.
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@The-Compiler @websurfer5
Add missing space to warning message (pythonGH-14915) …
3511772 
This typo was introduced in pythonGH-13409 when changing the message text.
@hugovk hugovk mentioned this pull request Dec 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tirkarthi tirkarthi

@asvetlov asvetlov asvetlov approved these changes

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

@rhettinger rhettinger Awaiting requested review from rhettinger

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@Carreau @jdemeyer @ilevkivskyi @miss-islington @bedevere-bot @asvetlov @tirkarthi @serhiy-storchaka @the-knights-who-say-ni @csabella