◐ Shell
reader mode source ↗
Skip to content

gh-101100: Fix Sphinx warnings in library/decimal.rst#134303

Merged
hugovk merged 2 commits into
mainfrom
unknown repository
May 20, 2025
Merged

gh-101100: Fix Sphinx warnings in library/decimal.rst#134303
hugovk merged 2 commits into
mainfrom
unknown repository

Conversation

@ghost

@ghost ghost commented May 20, 2025 •
edited by hugovk
Loading

Copy link
Copy Markdown

@ghost ghost requested review from AA-Turner and hugovk as code owners May 20, 2025 01:14
@bedevere-app bedevere-app Bot mentioned this pull request May 20, 2025
Open
hugovk
hugovk approved these changes May 20, 2025
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thanks!

@hugovk

hugovk commented May 20, 2025

Copy link
Copy Markdown
Member

Oh one more thing, while we're editing this file, we have a mix of "Sentence case" and "Title Case" headers.

Please could you change "Quick-start Tutorial" and "Floating-Point Notes" to "Quick-start tutorial" and "Floating-point notes"?

(re: https://devguide.python.org/documentation/style-guide/#capitalization)

@vstinner

vstinner commented May 20, 2025

Copy link
Copy Markdown
Member

cc @skirpichev

@skirpichev skirpichev self-requested a review May 20, 2025 12:17
Hide details View details @hugovk hugovk merged commit f3acbb7 into python:main May 20, 2025
24 checks passed
@miss-islington-app

miss-islington-app Bot commented May 20, 2025

Copy link
Copy Markdown

Thanks @koyuki7w for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 20, 2025
@miss-islington
pythongh-101100: Fix Sphinx warnings in library/decimal.rst (python… …
3f25591 
…GH-134303)

(cherry picked from commit f3acbb7)

Co-authored-by: Yuki Kobayashi <drsuaimqjgar@gmail.com>
@miss-islington-app

miss-islington-app Bot commented May 20, 2025

Copy link
Copy Markdown

Sorry, @koyuki7w and @hugovk, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker f3acbb72ff125172522545ec6f6c676f5108b109 3.13

@bedevere-app

bedevere-app Bot commented May 20, 2025

Copy link
Copy Markdown

GH-134338 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label May 20, 2025
hugovk pushed a commit to hugovk/cpython that referenced this pull request May 20, 2025
@hugovk
[3.13] pythongh-101100: Fix Sphinx warnings in library/decimal.rst (p… …
856ba55 
…ythonGH-134303)

(cherry picked from commit f3acbb7)

Co-authored-by: Yuki Kobayashi <drsuaimqjgar@gmail.com>
@bedevere-app

bedevere-app Bot commented May 20, 2025

Copy link
Copy Markdown

GH-134339 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the bugs and security fixes label May 20, 2025
@hugovk hugovk changed the title gh-101100: Fix sphinx warnings in library/decimal.rst May 20, 2025
hugovk pushed a commit that referenced this pull request May 20, 2025
@miss-islington
[3.14] gh-101100: Fix Sphinx warnings in library/decimal.rst (GH-13… …
ff0facd 
…4303) (#134338)

Co-authored-by: Yuki Kobayashi <drsuaimqjgar@gmail.com>
hugovk added a commit that referenced this pull request May 20, 2025
@hugovk
[3.13] gh-101100: Fix Sphinx warnings in library/decimal.rst (GH-13… …
61af847 
…4303) (#134339)

Co-authored-by: Yuki Kobayashi <drsuaimqjgar@gmail.com>
@ghost ghost deleted the doc-fix-2 branch May 20, 2025 23:48
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@Pranjal095
pythongh-101100: Fix Sphinx warnings in library/decimal.rst (python… …
2ebd6db 
…#134303)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@taegyunkim
pythongh-101100: Fix Sphinx warnings in library/decimal.rst (python… …
e1a1190 
…#134303)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Assignees

@hugovk hugovk

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hugovk @vstinner @skirpichev